* [patch] ASoC: wm2000: a couple harmless underflows
@ 2015-10-13 7:12 Dan Carpenter
2015-10-13 12:29 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-10-13 7:12 UTC (permalink / raw)
To: Liam Girdwood
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Charles Keepax,
Lars-Peter Clausen, Krzysztof Kozlowski, patches, alsa-devel,
kernel-janitors
We want these to be zero or one, but by mistake we also accept negative
values. It's harmless but we should still clean it up.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/wm2000.c b/sound/soc/codecs/wm2000.c
index 786abd0..a67ea10 100644
--- a/sound/soc/codecs/wm2000.c
+++ b/sound/soc/codecs/wm2000.c
@@ -620,7 +620,7 @@ static int wm2000_anc_mode_put(struct snd_kcontrol *kcontrol,
{
struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
struct wm2000_priv *wm2000 = dev_get_drvdata(codec->dev);
- int anc_active = ucontrol->value.integer.value[0];
+ unsigned int anc_active = ucontrol->value.integer.value[0];
int ret;
if (anc_active > 1)
@@ -653,7 +653,7 @@ static int wm2000_speaker_put(struct snd_kcontrol *kcontrol,
{
struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
struct wm2000_priv *wm2000 = dev_get_drvdata(codec->dev);
- int val = ucontrol->value.integer.value[0];
+ unsigned int val = ucontrol->value.integer.value[0];
int ret;
if (val > 1)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] ASoC: wm2000: a couple harmless underflows
2015-10-13 7:12 [patch] ASoC: wm2000: a couple harmless underflows Dan Carpenter
@ 2015-10-13 12:29 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2015-10-13 12:29 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Lars-Peter Clausen, Krzysztof Kozlowski, patches, alsa-devel,
kernel-janitors
On Tue, Oct 13, 2015 at 10:12:45AM +0300, Dan Carpenter wrote:
> We want these to be zero or one, but by mistake we also accept negative
> values. It's harmless but we should still clean it up.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-13 12:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 7:12 [patch] ASoC: wm2000: a couple harmless underflows Dan Carpenter
2015-10-13 12:29 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox