From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Alexander Morozov <linux@meltdown.ru>,
Mark Brown <broonie@kernel.org>, Bo Shen <voice.shen@atmel.com>
Subject: Re: [patch] ASoC: wm8904: harmless underflow in wm8904_put_deemph()
Date: Tue, 13 Oct 2015 12:27:11 +0000 [thread overview]
Message-ID: <20151013122711.GF8805@ck-lbox> (raw)
In-Reply-To: <20151013070818.GB31537@mwanda>
On Tue, Oct 13, 2015 at 10:08:18AM +0300, Dan Carpenter wrote:
> We try to check that "deemph" is zero or one, but because of an
> underflow bug, it can also be negative. It's fine, negative values are
> handled as non-zero. But it's messy and static checkers complain so
> let's fix it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
prev parent reply other threads:[~2015-10-13 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 7:08 [patch] ASoC: wm8904: harmless underflow in wm8904_put_deemph() Dan Carpenter
2015-10-13 12:27 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013122711.GF8805@ck-lbox \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=fabio.estevam@freescale.com \
--cc=k.kozlowski@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux@meltdown.ru \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox