* [patch] iwlwifi: mvm: rs: fix a warning message
@ 2015-11-21 10:33 Dan Carpenter
2015-11-21 18:24 ` Grumbach, Emmanuel
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-11-21 10:33 UTC (permalink / raw)
To: Johannes Berg
Cc: Emmanuel Grumbach, Intel Linux Wireless, Kalle Valo, Eyal Shapira,
Luca Coelho, Liad Kaufman, linux-wireless, kernel-janitors
WARN_ON_ONCE() doesn't take a message, it only takes a condition. I
have changed this to WARN(1, ...).
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/iwlwifi/mvm/rs.c b/drivers/net/wireless/iwlwifi/mvm/rs.c
index d1ad103..58d7bee 100644
--- a/drivers/net/wireless/iwlwifi/mvm/rs.c
+++ b/drivers/net/wireless/iwlwifi/mvm/rs.c
@@ -1827,7 +1827,7 @@ static int rs_switch_to_column(struct iwl_mvm *mvm,
rate->type = lq_sta->is_vht ? LQ_VHT_MIMO2 : LQ_HT_MIMO2;
rate_mask = lq_sta->active_mimo2_rate;
} else {
- WARN_ON_ONCE("Bad column mode");
+ WARN_ONCE(1, "Bad column mode");
}
if (column->mode != RS_LEGACY) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] iwlwifi: mvm: rs: fix a warning message
2015-11-21 10:33 [patch] iwlwifi: mvm: rs: fix a warning message Dan Carpenter
@ 2015-11-21 18:24 ` Grumbach, Emmanuel
0 siblings, 0 replies; 2+ messages in thread
From: Grumbach, Emmanuel @ 2015-11-21 18:24 UTC (permalink / raw)
To: Dan Carpenter, Berg, Johannes
Cc: linuxwifi, Kalle Valo, Eyal Shapira, Coelho, Luciano,
Kaufman, Liad, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
On 11/21/2015 12:33 PM, Dan Carpenter wrote:
> WARN_ON_ONCE() doesn't take a message, it only takes a condition. I
> have changed this to WARN(1, ...).
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/wireless/iwlwifi/mvm/rs.c b/drivers/net/wireless/iwlwifi/mvm/rs.c
> index d1ad103..58d7bee 100644
> --- a/drivers/net/wireless/iwlwifi/mvm/rs.c
> +++ b/drivers/net/wireless/iwlwifi/mvm/rs.c
> @@ -1827,7 +1827,7 @@ static int rs_switch_to_column(struct iwl_mvm *mvm,
> rate->type = lq_sta->is_vht ? LQ_VHT_MIMO2 : LQ_HT_MIMO2;
> rate_mask = lq_sta->active_mimo2_rate;
> } else {
> - WARN_ON_ONCE("Bad column mode");
> + WARN_ONCE(1, "Bad column mode");
> }
>
> if (column->mode != RS_LEGACY) {
>
Ouch - thanks. Clearly, this one doesn't trigger very often :)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-21 18:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-21 10:33 [patch] iwlwifi: mvm: rs: fix a warning message Dan Carpenter
2015-11-21 18:24 ` Grumbach, Emmanuel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox