* [PATCH] mfd: constify da903x_chip_ops structure
@ 2015-11-13 16:03 Julia Lawall
2015-11-24 16:30 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2015-11-13 16:03 UTC (permalink / raw)
To: Support Opensource; +Cc: kernel-janitors, Lee Jones, linux-kernel
The da903x_chip_ops structure is never modified, so declare it
as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/mfd/da903x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
index 37e4426..f6a0459 100644
--- a/drivers/mfd/da903x.c
+++ b/drivers/mfd/da903x.c
@@ -60,7 +60,7 @@ struct da903x_chip_ops {
struct da903x_chip {
struct i2c_client *client;
struct device *dev;
- struct da903x_chip_ops *ops;
+ const struct da903x_chip_ops *ops;
int type;
uint32_t events_mask;
@@ -424,7 +424,7 @@ static irqreturn_t da903x_irq_handler(int irq, void *data)
return IRQ_HANDLED;
}
-static struct da903x_chip_ops da903x_ops[] = {
+static const struct da903x_chip_ops da903x_ops[] = {
[0] = {
.init_chip = da9030_init_chip,
.unmask_events = da9030_unmask_events,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: constify da903x_chip_ops structure
2015-11-13 16:03 [PATCH] mfd: constify da903x_chip_ops structure Julia Lawall
@ 2015-11-24 16:30 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2015-11-24 16:30 UTC (permalink / raw)
To: Julia Lawall; +Cc: Support Opensource, kernel-janitors, linux-kernel
On Fri, 13 Nov 2015, Julia Lawall wrote:
> The da903x_chip_ops structure is never modified, so declare it
> as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/mfd/da903x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
> index 37e4426..f6a0459 100644
> --- a/drivers/mfd/da903x.c
> +++ b/drivers/mfd/da903x.c
> @@ -60,7 +60,7 @@ struct da903x_chip_ops {
> struct da903x_chip {
> struct i2c_client *client;
> struct device *dev;
> - struct da903x_chip_ops *ops;
> + const struct da903x_chip_ops *ops;
>
> int type;
> uint32_t events_mask;
> @@ -424,7 +424,7 @@ static irqreturn_t da903x_irq_handler(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> -static struct da903x_chip_ops da903x_ops[] = {
> +static const struct da903x_chip_ops da903x_ops[] = {
> [0] = {
> .init_chip = da9030_init_chip,
> .unmask_events = da9030_unmask_events,
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-24 16:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-13 16:03 [PATCH] mfd: constify da903x_chip_ops structure Julia Lawall
2015-11-24 16:30 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox