From: "Sinclair Yeh" <syeh@vmware.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>,
Thomas Hellstrom <thellstrom@vmware.com>,
Charmaine Lee <charmainel@vmware.com>,
Brian Paul <brianp@vmware.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/vmwgfx: fix a warning message
Date: Tue, 24 Nov 2015 19:55:49 +0000 [thread overview]
Message-ID: <20151124195528.GA32328@syeh-linux> (raw)
In-Reply-To: <20151121102939.GB7002@mwanda>
Thanks!
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
On Sat, Nov 21, 2015 at 01:29:39PM +0300, Dan Carpenter wrote:
> The WARN_ON() macro only takes a condition argument, it doesn't take
> a message. I have converted this to WARN() instead.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> index a8baf5f..b6a0806 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> @@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
> else if (ctx_id = SVGA3D_INVALID_ID)
> ret = vmw_local_fifo_reserve(dev_priv, bytes);
> else {
> - WARN_ON("Command buffer has not been allocated.\n");
> + WARN(1, "Command buffer has not been allocated.\n");
> ret = NULL;
> }
> if (IS_ERR_OR_NULL(ret)) {
prev parent reply other threads:[~2015-11-24 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 10:29 [patch] drm/vmwgfx: fix a warning message Dan Carpenter
2015-11-24 19:55 ` Sinclair Yeh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124195528.GA32328@syeh-linux \
--to=syeh@vmware.com \
--cc=airlied@linux.ie \
--cc=brianp@vmware.com \
--cc=charmainel@vmware.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox