* [patch] drm/vmwgfx: fix a warning message
@ 2015-11-21 10:29 Dan Carpenter
2015-11-24 19:55 ` Sinclair Yeh
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-11-21 10:29 UTC (permalink / raw)
To: David Airlie
Cc: Thomas Hellstrom, kernel-janitors, Jakob Bornecrantz, dri-devel,
Brian Paul, Charmaine Lee
The WARN_ON() macro only takes a condition argument, it doesn't take
a message. I have converted this to WARN() instead.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
index a8baf5f..b6a0806 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
@@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
else if (ctx_id = SVGA3D_INVALID_ID)
ret = vmw_local_fifo_reserve(dev_priv, bytes);
else {
- WARN_ON("Command buffer has not been allocated.\n");
+ WARN(1, "Command buffer has not been allocated.\n");
ret = NULL;
}
if (IS_ERR_OR_NULL(ret)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] drm/vmwgfx: fix a warning message
2015-11-21 10:29 [patch] drm/vmwgfx: fix a warning message Dan Carpenter
@ 2015-11-24 19:55 ` Sinclair Yeh
0 siblings, 0 replies; 2+ messages in thread
From: Sinclair Yeh @ 2015-11-24 19:55 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Thomas Hellstrom, Charmaine Lee, Brian Paul,
dri-devel, kernel-janitors
Thanks!
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
On Sat, Nov 21, 2015 at 01:29:39PM +0300, Dan Carpenter wrote:
> The WARN_ON() macro only takes a condition argument, it doesn't take
> a message. I have converted this to WARN() instead.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> index a8baf5f..b6a0806 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> @@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
> else if (ctx_id = SVGA3D_INVALID_ID)
> ret = vmw_local_fifo_reserve(dev_priv, bytes);
> else {
> - WARN_ON("Command buffer has not been allocated.\n");
> + WARN(1, "Command buffer has not been allocated.\n");
> ret = NULL;
> }
> if (IS_ERR_OR_NULL(ret)) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-24 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-21 10:29 [patch] drm/vmwgfx: fix a warning message Dan Carpenter
2015-11-24 19:55 ` Sinclair Yeh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox