[patch 3/3 -next] drm/vc4: fix an error code

[patch 3/3 -next] drm/vc4: fix an error code

[Dan Carpenter]

"exec->exec_bo" is NULL at this point so this code returns success.  We
want to return -ENOMEM.

Fixes: d5b1a78a772f ('drm/vc4: Add support for drawing 3D frames.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c
index 2a680d9..98a25b8 100644
--- a/drivers/gpu/drm/vc4/vc4_gem.c
+++ b/drivers/gpu/drm/vc4/vc4_gem.c
@@ -580,7 +580,7 @@ vc4_get_bcl(struct drm_device *dev, struct vc4_exec_info *exec)
 	bo = vc4_bo_create(dev, exec_size, true);
 	if (!bo) {
 		DRM_ERROR("Couldn't allocate BO for binning\n");
-		ret = PTR_ERR(exec->exec_bo);
+		ret = -ENOMEM;
 		goto fail;
 	}
 	exec->exec_bo = &bo->base;

Re: [patch 3/3 -next] drm/vc4: fix an error code

[Eric Anholt]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Dan Carpenter <dan.carpenter@oracle.com> writes:

> "exec->exec_bo" is NULL at this point so this code returns success.  We
> want to return -ENOMEM.
>
> Fixes: d5b1a78a772f ('drm/vc4: Add support for drawing 3D frames.')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks!  All 3 of these are Reviewed-by: Eric Anholt <eric@anholt.net>

I've pulled them to my -next tree, which I'll send to Dave once we get
the CONFIG_PM_SLEEP bits sorted out.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]