* [patch] spi: checking for NULL instead of IS_ERR
@ 2016-02-12 6:38 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-02-12 6:38 UTC (permalink / raw)
To: Mark Brown, Martin Sperl
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
spi_replace_transfers() returns error pointers on error, it never
returns NULL.
Fixes: d9f121227281 ('spi: core: add spi_split_transfers_maxsize')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 1413a6b..d459adc 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2284,8 +2284,8 @@ int __spi_split_transfer_maxsize(struct spi_master *master,
/* create replacement */
srt = spi_replace_transfers(msg, xfer, 1, count, NULL, 0, gfp);
- if (!srt)
- return -ENOMEM;
+ if (IS_ERR(srt))
+ return PTR_ERR(srt);
xfers = srt->inserted_transfers;
/* now handle each of those newly inserted spi_transfers
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-02-12 6:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-12 6:38 [patch] spi: checking for NULL instead of IS_ERR Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox