From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>,
Geunyoung Kim <nenggun.kim@samsung.com>,
Hans Verkuil <hansverk@cisco.com>,
Junghak Sung <jh1009.sung@samsung.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] [media] saa7134: Fix analog TV demod detection.
Date: Sat, 27 Feb 2016 10:46:16 +0000 [thread overview]
Message-ID: <20160227104616.GB14086@mwanda> (raw)
There is a missing curly brace so we only look at the first item in the
list and then exit.
Fixes: ac90aa02d5b9 ('[media] saa7134: add media controller support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/pci/saa7134/saa7134-core.c b/drivers/media/pci/saa7134/saa7134-core.c
index 42bc417..8f3ba40 100644
--- a/drivers/media/pci/saa7134/saa7134-core.c
+++ b/drivers/media/pci/saa7134/saa7134-core.c
@@ -838,9 +838,10 @@ static void saa7134_create_entities(struct saa7134_dev *dev)
/* Check if it is using an external analog TV demod */
media_device_for_each_entity(entity, dev->media_dev) {
- if (entity->function = MEDIA_ENT_F_ATV_DECODER)
+ if (entity->function = MEDIA_ENT_F_ATV_DECODER) {
decoder = entity;
break;
+ }
}
/*
reply other threads:[~2016-02-27 10:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160227104616.GB14086@mwanda \
--to=dan.carpenter@oracle.com \
--cc=hansverk@cisco.com \
--cc=jh1009.sung@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=nenggun.kim@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox