public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] [media] saa7134: Fix analog TV demod detection.
@ 2016-02-27 10:46 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-02-27 10:46 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Seung-Woo Kim, Geunyoung Kim, Hans Verkuil, Junghak Sung,
	linux-media, linux-kernel, kernel-janitors

There is a missing curly brace so we only look at the first item in the
list and then exit.

Fixes: ac90aa02d5b9 ('[media] saa7134: add media controller support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/media/pci/saa7134/saa7134-core.c b/drivers/media/pci/saa7134/saa7134-core.c
index 42bc417..8f3ba40 100644
--- a/drivers/media/pci/saa7134/saa7134-core.c
+++ b/drivers/media/pci/saa7134/saa7134-core.c
@@ -838,9 +838,10 @@ static void saa7134_create_entities(struct saa7134_dev *dev)
 
 	/* Check if it is using an external analog TV demod */
 	media_device_for_each_entity(entity, dev->media_dev) {
-		if (entity->function = MEDIA_ENT_F_ATV_DECODER)
+		if (entity->function = MEDIA_ENT_F_ATV_DECODER) {
 			decoder = entity;
 			break;
+		}
 	}
 
 	/*

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-02-27 10:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-27 10:46 [patch] [media] saa7134: Fix analog TV demod detection Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox