* [patch] intel_telemetry_pltdrv: silence an unintialized variable warning
@ 2016-04-15 14:45 Dan Carpenter
2016-04-18 4:28 ` Chakravarty, Souvik K
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-04-15 14:45 UTC (permalink / raw)
To: Souvik Kumar Chakravarty
Cc: Darren Hart, platform-driver-x86, linux-kernel, kernel-janitors
Presumably "pss_period" and "ioss_period" can't both be zero, but this
function is never called so we can't infer that using static analysis
alone.
Let's silence the warning by setting "ret" to zero.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index 397119f..781bd10 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -659,7 +659,7 @@ static int telemetry_plt_update_events(struct telemetry_evtconfig pss_evtconfig,
static int telemetry_plt_set_sampling_period(u8 pss_period, u8 ioss_period)
{
u32 telem_ctrl = 0;
- int ret;
+ int ret = 0;
mutex_lock(&(telm_conf->telem_lock));
if (ioss_period) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* RE: [patch] intel_telemetry_pltdrv: silence an unintialized variable warning
2016-04-15 14:45 [patch] intel_telemetry_pltdrv: silence an unintialized variable warning Dan Carpenter
@ 2016-04-18 4:28 ` Chakravarty, Souvik K
0 siblings, 0 replies; 2+ messages in thread
From: Chakravarty, Souvik K @ 2016-04-18 4:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: Darren Hart, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Looks good...thanks Dan.
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Friday, April 15, 2016 8:16 PM
> To: Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>
> Cc: Darren Hart <dvhart@infradead.org>; platform-driver-
> x86@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: [patch] intel_telemetry_pltdrv: silence an unintialized variable
> warning
>
> Presumably "pss_period" and "ioss_period" can't both be zero, but this
> function is never called so we can't infer that using static analysis alone.
>
> Let's silence the warning by setting "ret" to zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index 397119f..781bd10 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -659,7 +659,7 @@ static int telemetry_plt_update_events(struct
> telemetry_evtconfig pss_evtconfig, static int
> telemetry_plt_set_sampling_period(u8 pss_period, u8 ioss_period) {
> u32 telem_ctrl = 0;
> - int ret;
> + int ret = 0;
>
> mutex_lock(&(telm_conf->telem_lock));
> if (ioss_period) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-18 4:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-15 14:45 [patch] intel_telemetry_pltdrv: silence an unintialized variable warning Dan Carpenter
2016-04-18 4:28 ` Chakravarty, Souvik K
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox