* re: qed: Add RoCE ll2 & GSI support
@ 2016-10-11 7:33 Dan Carpenter
2016-10-13 6:58 ` Amrani, Ram
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-10-11 7:33 UTC (permalink / raw)
To: kernel-janitors
Hello Ram Amrani,
This is a semi-automatic email about new static checker warnings.
The patch abd49676c707: "qed: Add RoCE ll2 & GSI support" from Oct 1,
2016, leads to the following Smatch complaint:
drivers/net/ethernet/qlogic/qed/qed_roce.c:2812 qed_roce_ll2_stop()
warn: variable dereferenced before check 'cdev' (see line 2808)
drivers/net/ethernet/qlogic/qed/qed_roce.c
2807 {
2808 struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev);
2809 struct qed_roce_ll2_info *roce_ll2 = hwfn->ll2;
^^^^^^^^^
Deref.
2810 int rc;
2811
2812 if (!cdev) {
^^^^^
Checked too late.
2813 DP_ERR(cdev, "qed roce ll2 stop: invalid cdev\n");
2814 return -EINVAL;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: qed: Add RoCE ll2 & GSI support
2016-10-11 7:33 qed: Add RoCE ll2 & GSI support Dan Carpenter
@ 2016-10-13 6:58 ` Amrani, Ram
0 siblings, 0 replies; 2+ messages in thread
From: Amrani, Ram @ 2016-10-13 6:58 UTC (permalink / raw)
To: kernel-janitors
+Yuval
Thank you Dan. We'll take care of this as well.
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Tuesday, October 11, 2016 10:33 AM
> To: Amrani, Ram <Ram.Amrani@cavium.com>
> Cc: kernel-janitors@vger.kernel.org
> Subject: re: qed: Add RoCE ll2 & GSI support
>
> Hello Ram Amrani,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch abd49676c707: "qed: Add RoCE ll2 & GSI support" from Oct 1, 2016,
> leads to the following Smatch complaint:
>
> drivers/net/ethernet/qlogic/qed/qed_roce.c:2812 qed_roce_ll2_stop()
> warn: variable dereferenced before check 'cdev' (see line 2808)
>
> drivers/net/ethernet/qlogic/qed/qed_roce.c
> 2807 {
> 2808 struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev);
> 2809 struct qed_roce_ll2_info *roce_ll2 = hwfn->ll2;
> ^^^^^^^^^ Deref.
>
> 2810 int rc;
> 2811
> 2812 if (!cdev) {
> ^^^^^
> Checked too late.
>
> 2813 DP_ERR(cdev, "qed roce ll2 stop: invalid cdev\n");
> 2814 return -EINVAL;
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-13 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-11 7:33 qed: Add RoCE ll2 & GSI support Dan Carpenter
2016-10-13 6:58 ` Amrani, Ram
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox