* [patch] drm/imx: drm_dev_alloc() returns error pointers
@ 2016-10-13 8:53 Dan Carpenter
2016-10-13 12:40 ` Lucas Stach
2016-10-17 16:10 ` Philipp Zabel
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-10-13 8:53 UTC (permalink / raw)
To: Philipp Zabel, Lucas Stach; +Cc: kernel-janitors, dri-devel
We are checking for NULL here, when we should be checking for error
pointers.
Fixes: 54db5decce17 ("drm/imx: drop deprecated load/unload drm_driver ops")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index 98df09c..3acc976 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -357,8 +357,8 @@ static int imx_drm_bind(struct device *dev)
int ret;
drm = drm_dev_alloc(&imx_drm_driver, dev);
- if (!drm)
- return -ENOMEM;
+ if (IS_ERR(drm))
+ return PTR_ERR(drm);
imxdrm = devm_kzalloc(dev, sizeof(*imxdrm), GFP_KERNEL);
if (!imxdrm) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] drm/imx: drm_dev_alloc() returns error pointers
2016-10-13 8:53 [patch] drm/imx: drm_dev_alloc() returns error pointers Dan Carpenter
@ 2016-10-13 12:40 ` Lucas Stach
2016-10-17 16:10 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Lucas Stach @ 2016-10-13 12:40 UTC (permalink / raw)
To: Dan Carpenter, Philipp Zabel; +Cc: kernel-janitors, dri-devel
Am Donnerstag, den 13.10.2016, 11:53 +0300 schrieb Dan Carpenter:
> We are checking for NULL here, when we should be checking for error
> pointers.
>
> Fixes: 54db5decce17 ("drm/imx: drop deprecated load/unload drm_driver
> ops")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
>
> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c
> b/drivers/gpu/drm/imx/imx-drm-core.c
> index 98df09c..3acc976 100644
> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> @@ -357,8 +357,8 @@ static int imx_drm_bind(struct device *dev)
> int ret;
>
> drm = drm_dev_alloc(&imx_drm_driver, dev);
> - if (!drm)
> - return -ENOMEM;
> + if (IS_ERR(drm))
> + return PTR_ERR(drm);
>
> imxdrm = devm_kzalloc(dev, sizeof(*imxdrm), GFP_KERNEL);
> if (!imxdrm) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] drm/imx: drm_dev_alloc() returns error pointers
2016-10-13 8:53 [patch] drm/imx: drm_dev_alloc() returns error pointers Dan Carpenter
2016-10-13 12:40 ` Lucas Stach
@ 2016-10-17 16:10 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2016-10-17 16:10 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, dri-devel
Am Donnerstag, den 13.10.2016, 11:53 +0300 schrieb Dan Carpenter:
> We are checking for NULL here, when we should be checking for error
> pointers.
>
> Fixes: 54db5decce17 ("drm/imx: drop deprecated load/unload drm_driver ops")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> index 98df09c..3acc976 100644
> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> @@ -357,8 +357,8 @@ static int imx_drm_bind(struct device *dev)
> int ret;
>
> drm = drm_dev_alloc(&imx_drm_driver, dev);
> - if (!drm)
> - return -ENOMEM;
> + if (IS_ERR(drm))
> + return PTR_ERR(drm);
>
> imxdrm = devm_kzalloc(dev, sizeof(*imxdrm), GFP_KERNEL);
> if (!imxdrm) {
Applied, thanks.
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-17 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-13 8:53 [patch] drm/imx: drm_dev_alloc() returns error pointers Dan Carpenter
2016-10-13 12:40 ` Lucas Stach
2016-10-17 16:10 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox