* [PATCH][net-next] esp6: fix incorrect null pointer check on xo
@ 2017-04-18 14:06 Colin King
2017-04-18 20:11 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-04-18 14:06 UTC (permalink / raw)
To: David S . Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The check for xo being null is incorrect, currently it is checking
for non-null, it should be checking for null.
Detected with CoverityScan, CID#1429349 ("Dereference after null check")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/ipv6/esp6_offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/esp6_offload.c b/net/ipv6/esp6_offload.c
index 1cceeee7cc33..95f10728abaa 100644
--- a/net/ipv6/esp6_offload.c
+++ b/net/ipv6/esp6_offload.c
@@ -120,7 +120,7 @@ static struct sk_buff *esp6_gso_segment(struct sk_buff *skb,
netdev_features_t esp_features = features;
struct xfrm_offload *xo = xfrm_offload(skb);
- if (xo)
+ if (!xo)
goto out;
seq = xo->seq.low;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH][net-next] esp6: fix incorrect null pointer check on xo
2017-04-18 14:06 [PATCH][net-next] esp6: fix incorrect null pointer check on xo Colin King
@ 2017-04-18 20:11 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-04-18 20:11 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev, kernel-janitors,
linux-kernel
It's in Steffen's tree, not the networking tree and he's not CC'd. You
should really be adding Fixes tags because it helps to ensure you CC the
guilty parties.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-18 20:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-18 14:06 [PATCH][net-next] esp6: fix incorrect null pointer check on xo Colin King
2017-04-18 20:11 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox