* [PATCH net] liquidio: silence a locking static checker warning
@ 2017-04-28 12:57 Dan Carpenter
2017-04-28 17:42 ` Felix Manlunas
2017-05-01 2:42 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-04-28 12:57 UTC (permalink / raw)
To: Derek Chickles
Cc: Satanand Burla, Felix Manlunas, Raghu Vatsavayi, netdev,
kernel-janitors
Presumably we never hit this return, but static checkers complain that
we need to unlock so we may as well fix that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c
index 201b9875f9bb..5cca73b8880b 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c
@@ -313,6 +313,7 @@ int octeon_mbox_process_message(struct octeon_mbox *mbox)
return 0;
}
+ spin_unlock_irqrestore(&mbox->lock, flags);
WARN_ON(1);
return 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] liquidio: silence a locking static checker warning
2017-04-28 12:57 [PATCH net] liquidio: silence a locking static checker warning Dan Carpenter
@ 2017-04-28 17:42 ` Felix Manlunas
2017-05-01 2:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Felix Manlunas @ 2017-04-28 17:42 UTC (permalink / raw)
To: Dan Carpenter
Cc: Derek Chickles, Satanand Burla, Raghu Vatsavayi, netdev,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 28 Apr 2017 15:57:15 +0300
> Presumably we never hit this return, but static checkers complain that
> we need to unlock so we may as well fix that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c
> index 201b9875f9bb..5cca73b8880b 100644
> --- a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c
> +++ b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c
> @@ -313,6 +313,7 @@ int octeon_mbox_process_message(struct octeon_mbox *mbox)
> return 0;
> }
>
> + spin_unlock_irqrestore(&mbox->lock, flags);
> WARN_ON(1);
>
> return 0;
Thanks.
Acked-by: Felix Manlunas <felix.manlunas@cavium.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] liquidio: silence a locking static checker warning
2017-04-28 12:57 [PATCH net] liquidio: silence a locking static checker warning Dan Carpenter
2017-04-28 17:42 ` Felix Manlunas
@ 2017-05-01 2:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-05-01 2:42 UTC (permalink / raw)
To: dan.carpenter
Cc: derek.chickles, satananda.burla, felix.manlunas, raghu.vatsavayi,
netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 28 Apr 2017 15:57:15 +0300
> Presumably we never hit this return, but static checkers complain that
> we need to unlock so we may as well fix that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-01 2:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-28 12:57 [PATCH net] liquidio: silence a locking static checker warning Dan Carpenter
2017-04-28 17:42 ` Felix Manlunas
2017-05-01 2:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox