From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb: max3421: unlock on error in max3421_hub_control()
Date: Fri, 27 Oct 2017 12:16:43 +0000 [thread overview]
Message-ID: <20171027121643.2ep2fryouzkrffjl@mwanda> (raw)
In-Reply-To: <20171027062620.emm5wwdv73kjjpvl@mwanda>
On Fri, Oct 27, 2017 at 02:08:38PM +0200, Jules Maselbas wrote:
>
> > On Fri, Oct 27, 2017 at 11:06:36AM +0200, Jules Maselbas wrote:
> >> Hi,
> >>
> >> > We can't return directly in max3421_hub_control(), we have to unlock
> >> > first.
> >> Yes you are right.
> >> I think testing if pdata is null is not necessary as driver_probe will fail if
> >> the device do not have a platform_data.
> >>
> >
> > In that case, let's drop my patch. Could you send a patch for which
> > removes the NULL check and add a Reported-by: for me?
> It is already in the v2 (and v3) of my initial patch.
> https://www.spinics.net/lists/devicetree/msg199901.html
>
> Should I make a brand new patch (not another version)?
Yeah. Greg never rebases once the tree has been shared with the public
so you'll need to send a new patch instead of a v3.
regards,
dan carpenter
prev parent reply other threads:[~2017-10-27 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 6:26 [PATCH] usb: max3421: unlock on error in max3421_hub_control() Dan Carpenter
2017-10-27 9:06 ` Jules Maselbas
2017-10-27 9:36 ` Dan Carpenter
2017-10-27 12:08 ` Jules Maselbas
2017-10-27 12:16 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027121643.2ep2fryouzkrffjl@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox