* [PATCH] net: ethernet: slicoss: remove redundant initialization of idx
@ 2017-10-29 13:38 Colin King
2017-10-30 17:36 ` Lino Sanfilippo
2017-10-30 18:04 ` Jakub Kicinski
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2017-10-29 13:38 UTC (permalink / raw)
To: Lino Sanfilippo, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable idx is being initialized and later on over-written by
a new value in a do-loop without the initial value ever being
read. Hence the initializion is redundant and can be removed.
Cleans up clang warning:
drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
stored to 'idx' during its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/alacritech/slicoss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
index 15a8096c60df..ac8004186fa8 100644
--- a/drivers/net/ethernet/alacritech/slicoss.c
+++ b/drivers/net/ethernet/alacritech/slicoss.c
@@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev)
{
struct slic_tx_queue *txq = &sdev->txq;
struct net_device *dev = sdev->netdev;
- unsigned int idx = txq->done_idx;
+ unsigned int idx;
struct slic_tx_buffer *buff;
unsigned int frames = 0;
unsigned int bytes = 0;
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx
2017-10-29 13:38 [PATCH] net: ethernet: slicoss: remove redundant initialization of idx Colin King
@ 2017-10-30 17:36 ` Lino Sanfilippo
2017-10-30 18:04 ` Jakub Kicinski
1 sibling, 0 replies; 4+ messages in thread
From: Lino Sanfilippo @ 2017-10-30 17:36 UTC (permalink / raw)
To: Colin King, netdev; +Cc: kernel-janitors, linux-kernel
Hi Colin,
On 29.10.2017 14:38, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable idx is being initialized and later on over-written by
> a new value in a do-loop without the initial value ever being
> read. Hence the initializion is redundant and can be removed.
> Cleans up clang warning:
>
> drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
> stored to 'idx' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/alacritech/slicoss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index 15a8096c60df..ac8004186fa8 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev)
> {
> struct slic_tx_queue *txq = &sdev->txq;
> struct net_device *dev = sdev->netdev;
> - unsigned int idx = txq->done_idx;
> + unsigned int idx;
> struct slic_tx_buffer *buff;
> unsigned int frames = 0;
> unsigned int bytes = 0;
>
Acked-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Regards,
Lino
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx
2017-10-29 13:38 [PATCH] net: ethernet: slicoss: remove redundant initialization of idx Colin King
2017-10-30 17:36 ` Lino Sanfilippo
@ 2017-10-30 18:04 ` Jakub Kicinski
2017-10-30 18:23 ` Lino Sanfilippo
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2017-10-30 18:04 UTC (permalink / raw)
To: Colin King; +Cc: Lino Sanfilippo, netdev, kernel-janitors, linux-kernel
On Sun, 29 Oct 2017 13:38:09 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable idx is being initialized and later on over-written by
> a new value in a do-loop without the initial value ever being
> read. Hence the initializion is redundant and can be removed.
> Cleans up clang warning:
>
> drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
> stored to 'idx' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/alacritech/slicoss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index 15a8096c60df..ac8004186fa8 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev)
> {
> struct slic_tx_queue *txq = &sdev->txq;
> struct net_device *dev = sdev->netdev;
> - unsigned int idx = txq->done_idx;
> + unsigned int idx;
> struct slic_tx_buffer *buff;
> unsigned int frames = 0;
> unsigned int bytes = 0;
You should probably reorder the variables now so they stay longest to
shortest.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx
2017-10-30 18:04 ` Jakub Kicinski
@ 2017-10-30 18:23 ` Lino Sanfilippo
0 siblings, 0 replies; 4+ messages in thread
From: Lino Sanfilippo @ 2017-10-30 18:23 UTC (permalink / raw)
To: Jakub Kicinski, Colin King; +Cc: netdev, kernel-janitors, linux-kernel
On 30.10.2017 19:04, Jakub Kicinski wrote:
> On Sun, 29 Oct 2017 13:38:09 +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Variable idx is being initialized and later on over-written by
>> a new value in a do-loop without the initial value ever being
>> read. Hence the initializion is redundant and can be removed.
>> Cleans up clang warning:
>>
>> drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
>> stored to 'idx' during its initialization is never read
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/net/ethernet/alacritech/slicoss.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
>> index 15a8096c60df..ac8004186fa8 100644
>> --- a/drivers/net/ethernet/alacritech/slicoss.c
>> +++ b/drivers/net/ethernet/alacritech/slicoss.c
>> @@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev)
>> {
>> struct slic_tx_queue *txq = &sdev->txq;
>> struct net_device *dev = sdev->netdev;
>> - unsigned int idx = txq->done_idx;
>> + unsigned int idx;
>> struct slic_tx_buffer *buff;
>> unsigned int frames = 0;
>> unsigned int bytes = 0;
>
> You should probably reorder the variables now so they stay longest to
> shortest.
>
I agree. While the change itself is ok, it would be nice if
we could keep the order of the variables by length.
Regards,
Lino
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-30 18:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-29 13:38 [PATCH] net: ethernet: slicoss: remove redundant initialization of idx Colin King
2017-10-30 17:36 ` Lino Sanfilippo
2017-10-30 18:04 ` Jakub Kicinski
2017-10-30 18:23 ` Lino Sanfilippo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox