* [PATCH] ixgbe: Fix && vs || typo
@ 2018-01-11 21:46 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2018-01-11 21:46 UTC (permalink / raw)
To: kernel-janitors
"offset" can't be both 0x0 and 0xFFFF so presumably || was intended
instead of &&. That matches with how this check is done in other
functions.
Fixes: 73834aec7199 ("ixgbe: extend firmware version support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
index 1948e4208fb4..27de8a7f2aeb 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
@@ -4084,7 +4084,7 @@ void ixgbe_get_oem_prod_version(struct ixgbe_hw *hw,
hw->eeprom.ops.read(hw, NVM_OEM_PROD_VER_PTR, &offset);
/* Return is offset to OEM Product Version block is invalid */
- if (offset = 0x0 && offset = NVM_INVALID_PTR)
+ if (offset = 0x0 || offset = NVM_INVALID_PTR)
return;
/* Read product version block */
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-01-11 21:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-11 21:46 [PATCH] ixgbe: Fix && vs || typo Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox