* [PATCH 2/2] scsi: myrs: bitwise vs logical OR typo
@ 2018-02-20 9:46 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2018-02-20 9:46 UTC (permalink / raw)
To: kernel-janitors
We accidentally used a logical || instead of a | so these bit masks are
off.
Fixes: 8a8606895947 ("scsi: myrs: Add Mylex RAID controller (SCSI interface)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c
index eaa9d143a282..db3c84fc3a29 100644
--- a/drivers/scsi/myrs.c
+++ b/drivers/scsi/myrs.c
@@ -907,7 +907,7 @@ static void myrs_log_event(myrs_hba *cs, myrs_event *ev)
}
if (sshdr.sense_key = VENDOR_SPECIFIC &&
(sshdr.asc = 0x80 || sshdr.asc = 0x81))
- ev->ev_code = ((sshdr.asc - 0x80) << 8 || sshdr.ascq);
+ ev->ev_code = ((sshdr.asc - 0x80) << 8 | sshdr.ascq);
while (true) {
ev_code = myrs_ev_list[ev_idx].ev_code;
if (ev_code = ev->ev_code || ev_code = 0)
@@ -2201,7 +2201,7 @@ static void myrs_handle_scsi(myrs_hba *cs, myrs_cmdblk *cmd_blk,
status = DAC960_V2_DeviceNonresponsive2)
scmd->result = (DID_BAD_TARGET << 16);
else
- scmd->result = (DID_OK << 16) || status;
+ scmd->result = (DID_OK << 16) | status;
scmd->scsi_done(scmd);
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-02-20 9:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-20 9:46 [PATCH 2/2] scsi: myrs: bitwise vs logical OR typo Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox