* [PATCH] firmware-gsmi: make structure gsmi_dev static
@ 2018-06-01 13:19 Colin King
2018-06-04 11:54 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-06-01 13:19 UTC (permalink / raw)
To: Jean Delvare; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The structure gsmi_dev is local to the source and does not need to be
in global scope, so make it static.
Cleans up sparse warning:
drivers/firmware/google/gsmi.c:96:3: warning: symbol 'gsmi_dev' was
not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/firmware/google/gsmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
index c8f169bf2e27..734146eec1b9 100644
--- a/drivers/firmware/google/gsmi.c
+++ b/drivers/firmware/google/gsmi.c
@@ -84,7 +84,7 @@ struct gsmi_buf {
u32 address; /* physical address of buffer */
};
-struct gsmi_device {
+static struct gsmi_device {
struct platform_device *pdev; /* platform device */
struct gsmi_buf *name_buf; /* variable name buffer */
struct gsmi_buf *data_buf; /* generic data buffer */
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] firmware-gsmi: make structure gsmi_dev static
2018-06-01 13:19 [PATCH] firmware-gsmi: make structure gsmi_dev static Colin King
@ 2018-06-04 11:54 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2018-06-04 11:54 UTC (permalink / raw)
To: Colin King; +Cc: kernel-janitors, linux-kernel
On Fri, 1 Jun 2018 14:19:39 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure gsmi_dev is local to the source and does not need to be
> in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/firmware/google/gsmi.c:96:3: warning: symbol 'gsmi_dev' was
> not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/firmware/google/gsmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
> index c8f169bf2e27..734146eec1b9 100644
> --- a/drivers/firmware/google/gsmi.c
> +++ b/drivers/firmware/google/gsmi.c
> @@ -84,7 +84,7 @@ struct gsmi_buf {
> u32 address; /* physical address of buffer */
> };
>
> -struct gsmi_device {
> +static struct gsmi_device {
> struct platform_device *pdev; /* platform device */
> struct gsmi_buf *name_buf; /* variable name buffer */
> struct gsmi_buf *data_buf; /* generic data buffer */
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-04 11:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-01 13:19 [PATCH] firmware-gsmi: make structure gsmi_dev static Colin King
2018-06-04 11:54 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox