* [PATCH] mtd: nftl: remove redundant variable nb_erases
@ 2018-07-04 6:46 Colin King
2018-07-07 10:04 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-07-04 6:46 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger, linux-mtd
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable nb_erases is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'nb_erases' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mtd/nftlmount.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
index 27184e3874db..91b7fb326f9a 100644
--- a/drivers/mtd/nftlmount.c
+++ b/drivers/mtd/nftlmount.c
@@ -577,7 +577,7 @@ static int get_fold_mark(struct NFTLrecord *nftl, unsigned int block)
int NFTL_mount(struct NFTLrecord *s)
{
int i;
- unsigned int first_logical_block, logical_block, rep_block, nb_erases, erase_mark;
+ unsigned int first_logical_block, logical_block, rep_block, erase_mark;
unsigned int block, first_block, is_first_block;
int chain_length, do_format_chain;
struct nftl_uci0 h0;
@@ -621,7 +621,6 @@ int NFTL_mount(struct NFTLrecord *s)
logical_block = le16_to_cpu ((h0.VirtUnitNum | h0.SpareVirtUnitNum));
rep_block = le16_to_cpu ((h0.ReplUnitNum | h0.SpareReplUnitNum));
- nb_erases = le32_to_cpu (h1.WearInfo);
erase_mark = le16_to_cpu ((h1.EraseMark | h1.EraseMark1));
is_first_block = !(logical_block >> 15);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mtd: nftl: remove redundant variable nb_erases
2018-07-04 6:46 [PATCH] mtd: nftl: remove redundant variable nb_erases Colin King
@ 2018-07-07 10:04 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2018-07-07 10:04 UTC (permalink / raw)
To: Colin King
Cc: David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger,
linux-mtd, kernel-janitors, linux-kernel
On Wed, 4 Jul 2018 07:46:09 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable nb_erases is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'nb_erases' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Thanks,
Boris
> ---
> drivers/mtd/nftlmount.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
> index 27184e3874db..91b7fb326f9a 100644
> --- a/drivers/mtd/nftlmount.c
> +++ b/drivers/mtd/nftlmount.c
> @@ -577,7 +577,7 @@ static int get_fold_mark(struct NFTLrecord *nftl, unsigned int block)
> int NFTL_mount(struct NFTLrecord *s)
> {
> int i;
> - unsigned int first_logical_block, logical_block, rep_block, nb_erases, erase_mark;
> + unsigned int first_logical_block, logical_block, rep_block, erase_mark;
> unsigned int block, first_block, is_first_block;
> int chain_length, do_format_chain;
> struct nftl_uci0 h0;
> @@ -621,7 +621,6 @@ int NFTL_mount(struct NFTLrecord *s)
>
> logical_block = le16_to_cpu ((h0.VirtUnitNum | h0.SpareVirtUnitNum));
> rep_block = le16_to_cpu ((h0.ReplUnitNum | h0.SpareReplUnitNum));
> - nb_erases = le32_to_cpu (h1.WearInfo);
> erase_mark = le16_to_cpu ((h1.EraseMark | h1.EraseMark1));
>
> is_first_block = !(logical_block >> 15);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-07 10:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-04 6:46 [PATCH] mtd: nftl: remove redundant variable nb_erases Colin King
2018-07-07 10:04 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox