* [PATCH net-next] mt76x0: pci: fix set external PA I/O current
@ 2018-10-08 13:21 YueHaibing
2018-10-08 13:29 ` Lorenzo Bianconi
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: YueHaibing @ 2018-10-08 13:21 UTC (permalink / raw)
To: Kalle Valo, Felix Fietkau, Lorenzo Bianconi, Stanislaw Gruszka
Cc: YueHaibing, linux-wireless, kernel-janitors, netdev, linux-kernel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/mediatek/mt76/mt76x0/pci.c: In function 'mt76x0e_register_device':
drivers/net/wireless/mediatek/mt76/mt76x0/pci.c:107:8: warning:
variable 'data' set but not used [-Wunused-but-set-variable]
It seems correct value to write is 'data'
Fixes: 2b2cb40bcd7d ("mt76x0: pci: add hw initialization at bootstrap")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/mediatek/mt76/mt76x0/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
index 87997cd..0426c68 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
@@ -106,12 +106,12 @@ static int mt76x0e_register_device(struct mt76x02_dev *dev)
if (val & MT_EE_NIC_CONF_0_PA_IO_CURRENT) {
u32 data;
- /* set external external PA I/O
+ /* set external PA I/O
* current to 16mA
*/
data = mt76_rr(dev, 0x11c);
- val |= 0xc03;
- mt76_wr(dev, 0x11c, val);
+ data |= 0xc03;
+ mt76_wr(dev, 0x11c, data);
}
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] mt76x0: pci: fix set external PA I/O current
2018-10-08 13:21 [PATCH net-next] mt76x0: pci: fix set external PA I/O current YueHaibing
@ 2018-10-08 13:29 ` Lorenzo Bianconi
2018-10-08 18:02 ` David Miller
2018-10-09 1:45 ` [PATCH v2] " YueHaibing
2 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Bianconi @ 2018-10-08 13:29 UTC (permalink / raw)
To: YueHaibing
Cc: Kalle Valo, Felix Fietkau, Stanislaw Gruszka, linux-wireless,
kernel-janitors, netdev
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/mediatek/mt76/mt76x0/pci.c: In function 'mt76x0e_register_device':
> drivers/net/wireless/mediatek/mt76/mt76x0/pci.c:107:8: warning:
> variable 'data' set but not used [-Wunused-but-set-variable]
>
> It seems correct value to write is 'data'
>
> Fixes: 2b2cb40bcd7d ("mt76x0: pci: add hw initialization at bootstrap")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] mt76x0: pci: fix set external PA I/O current
2018-10-08 13:21 [PATCH net-next] mt76x0: pci: fix set external PA I/O current YueHaibing
2018-10-08 13:29 ` Lorenzo Bianconi
@ 2018-10-08 18:02 ` David Miller
2018-10-09 1:24 ` YueHaibing
2018-10-09 1:45 ` [PATCH v2] " YueHaibing
2 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2018-10-08 18:02 UTC (permalink / raw)
To: yuehaibing
Cc: kvalo, nbd, lorenzo.bianconi, sgruszka, linux-wireless,
kernel-janitors, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Mon, 8 Oct 2018 13:21:49 +0000
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/mediatek/mt76/mt76x0/pci.c: In function 'mt76x0e_register_device':
> drivers/net/wireless/mediatek/mt76/mt76x0/pci.c:107:8: warning:
> variable 'data' set but not used [-Wunused-but-set-variable]
>
> It seems correct value to write is 'data'
>
> Fixes: 2b2cb40bcd7d ("mt76x0: pci: add hw initialization at bootstrap")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Wireless changes should be marked as appropriate in the Subject line
for targetting the wireless GIT tree, not "net-next".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] mt76x0: pci: fix set external PA I/O current
2018-10-08 18:02 ` David Miller
@ 2018-10-09 1:24 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2018-10-09 1:24 UTC (permalink / raw)
To: David Miller
Cc: kvalo, nbd, lorenzo.bianconi, sgruszka, linux-wireless,
kernel-janitors, netdev, linux-kernel
On 2018/10/9 2:02, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Mon, 8 Oct 2018 13:21:49 +0000
>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/mediatek/mt76/mt76x0/pci.c: In function 'mt76x0e_register_device':
>> drivers/net/wireless/mediatek/mt76/mt76x0/pci.c:107:8: warning:
>> variable 'data' set but not used [-Wunused-but-set-variable]
>>
>> It seems correct value to write is 'data'
>>
>> Fixes: 2b2cb40bcd7d ("mt76x0: pci: add hw initialization at bootstrap")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Wireless changes should be marked as appropriate in the Subject line
> for targetting the wireless GIT tree, not "net-next".
Ok, will fix it in v2.
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] mt76x0: pci: fix set external PA I/O current
2018-10-08 13:21 [PATCH net-next] mt76x0: pci: fix set external PA I/O current YueHaibing
2018-10-08 13:29 ` Lorenzo Bianconi
2018-10-08 18:02 ` David Miller
@ 2018-10-09 1:45 ` YueHaibing
2 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2018-10-09 1:45 UTC (permalink / raw)
To: Kalle Valo, Felix Fietkau, Lorenzo Bianconi, Stanislaw Gruszka
Cc: YueHaibing, linux-wireless, kernel-janitors, netdev, linux-kernel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/mediatek/mt76/mt76x0/pci.c: In function 'mt76x0e_register_device':
drivers/net/wireless/mediatek/mt76/mt76x0/pci.c:107:8: warning:
variable 'data' set but not used [-Wunused-but-set-variable]
It seems correct value to write is 'data'
Fixes: 2b2cb40bcd7d ("mt76x0: pci: add hw initialization at bootstrap")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
v2: remove 'net-next' from patch title
---
drivers/net/wireless/mediatek/mt76/mt76x0/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
index 87997cd..0426c68 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
@@ -106,12 +106,12 @@ static int mt76x0e_register_device(struct mt76x02_dev *dev)
if (val & MT_EE_NIC_CONF_0_PA_IO_CURRENT) {
u32 data;
- /* set external external PA I/O
+ /* set external PA I/O
* current to 16mA
*/
data = mt76_rr(dev, 0x11c);
- val |= 0xc03;
- mt76_wr(dev, 0x11c, val);
+ data |= 0xc03;
+ mt76_wr(dev, 0x11c, data);
}
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-09 1:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-08 13:21 [PATCH net-next] mt76x0: pci: fix set external PA I/O current YueHaibing
2018-10-08 13:29 ` Lorenzo Bianconi
2018-10-08 18:02 ` David Miller
2018-10-09 1:24 ` YueHaibing
2018-10-09 1:45 ` [PATCH v2] " YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox