[PATCH] perf/core: clean up inconsisent indentation

[PATCH] perf/core: clean up inconsisent indentation

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

Replace a bunch of spaces with tab, cleans up indentation

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 8c490130c4fb..84530ab358c3 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -750,7 +750,7 @@ static inline void update_cgrp_time_from_event(struct perf_event *event)
 	/*
 	 * Do not update time when cgroup is not active
 	 */
-       if (cgroup_is_descendant(cgrp->css.cgroup, event->cgrp->css.cgroup))
+	if (cgroup_is_descendant(cgrp->css.cgroup, event->cgrp->css.cgroup))
 		__update_cgrp_time(event->cgrp);
 }
 
-- 
2.19.1

Re: [PATCH] perf/core: clean up inconsisent indentation

[Arnaldo Carvalho de Melo]

Em Mon, Oct 29, 2018 at 11:32:11PM +0000, Colin King escreveu:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Replace a bunch of spaces with tab, cleans up indentation

I think we can live with the spaces as the 'git blame' information is
more valuable, i.e. who was that touched that line last?

Thanks,

- Arnaldo
 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 8c490130c4fb..84530ab358c3 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -750,7 +750,7 @@ static inline void update_cgrp_time_from_event(struct perf_event *event)
>  	/*
>  	 * Do not update time when cgroup is not active
>  	 */
> -       if (cgroup_is_descendant(cgrp->css.cgroup, event->cgrp->css.cgroup))
> +	if (cgroup_is_descendant(cgrp->css.cgroup, event->cgrp->css.cgroup))
>  		__update_cgrp_time(event->cgrp);
>  }
>  
> -- 
> 2.19.1

Re: [PATCH] perf/core: clean up inconsisent indentation

[Dan Carpenter]

On Tue, Oct 30, 2018 at 11:44:44AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 29, 2018 at 11:32:11PM +0000, Colin King escreveu:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > Replace a bunch of spaces with tab, cleans up indentation
> 
> I think we can live with the spaces as the 'git blame' information is
> more valuable, i.e. who was that touched that line last?
> 

You can use "git blame -w" to ignore white space changes.  I add it
whenever I run blame.

regards,
dan carpenter

Re: [PATCH] perf/core: clean up inconsisent indentation

[Arnaldo Carvalho de Melo]

Em Tue, Oct 30, 2018 at 10:25:31PM +0300, Dan Carpenter escreveu:
> On Tue, Oct 30, 2018 at 11:44:44AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Oct 29, 2018 at 11:32:11PM +0000, Colin King escreveu:
> > > From: Colin Ian King <colin.king@canonical.com>

> > > Replace a bunch of spaces with tab, cleans up indentation

> > I think we can live with the spaces as the 'git blame' information is
> > more valuable, i.e. who was that touched that line last?
 
> You can use "git blame -w" to ignore white space changes.  I add it
> whenever I run blame.

Great! I didn't knew that, will try and get this to be the default for
'git blame' in my machines.

Thanks,

- Arnaldo