From: Leon Romanovsky <leon@kernel.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg()
Date: Fri, 16 Nov 2018 01:59:50 +0000 [thread overview]
Message-ID: <20181116015950.GE24359@mtr-leonro.mtl.com> (raw)
In-Reply-To: <1542279300-104731-1-git-send-email-yuehaibing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 455 bytes --]
On Thu, Nov 15, 2018 at 10:55:00AM +0000, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
>
> There is no need to have the 'struct se_portal_group *tpg' variable
> static since new value always be assigned before use it.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2018-11-16 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 10:55 [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg() YueHaibing
2018-11-16 1:59 ` Leon Romanovsky [this message]
2018-11-20 3:43 ` Bart Van Assche
2018-11-21 23:51 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116015950.GE24359@mtr-leonro.mtl.com \
--to=leon@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox