* [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg()
@ 2018-11-15 10:55 YueHaibing
2018-11-16 1:59 ` Leon Romanovsky
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2018-11-15 10:55 UTC (permalink / raw)
To: kernel-janitors
From: Yue Haibing <yuehaibing@huawei.com>
There is no need to have the 'struct se_portal_group *tpg' variable
static since new value always be assigned before use it.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 1ae638b..fe02fab 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -3602,7 +3602,7 @@ static struct se_portal_group *srpt_make_tpg(struct se_wwn *wwn,
const char *name)
{
struct srpt_port *sport = wwn->priv;
- static struct se_portal_group *tpg;
+ struct se_portal_group *tpg;
int res;
WARN_ON_ONCE(wwn != &sport->port_guid_wwn &&
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg()
2018-11-15 10:55 [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg() YueHaibing
@ 2018-11-16 1:59 ` Leon Romanovsky
2018-11-20 3:43 ` Bart Van Assche
2018-11-21 23:51 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2018-11-16 1:59 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 455 bytes --]
On Thu, Nov 15, 2018 at 10:55:00AM +0000, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
>
> There is no need to have the 'struct se_portal_group *tpg' variable
> static since new value always be assigned before use it.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg()
2018-11-15 10:55 [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg() YueHaibing
2018-11-16 1:59 ` Leon Romanovsky
@ 2018-11-20 3:43 ` Bart Van Assche
2018-11-21 23:51 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2018-11-20 3:43 UTC (permalink / raw)
To: kernel-janitors
On 11/15/18 2:55 AM, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
>
> There is no need to have the 'struct se_portal_group *tpg' variable
> static since new value always be assigned before use it.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg()
2018-11-15 10:55 [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg() YueHaibing
2018-11-16 1:59 ` Leon Romanovsky
2018-11-20 3:43 ` Bart Van Assche
@ 2018-11-21 23:51 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2018-11-21 23:51 UTC (permalink / raw)
To: kernel-janitors
On Thu, Nov 15, 2018 at 10:55:00AM +0000, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
>
> There is no need to have the 'struct se_portal_group *tpg' variable
> static since new value always be assigned before use it.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next
Thanks,
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-21 23:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-15 10:55 [PATCH -next] IB/srpt: Drop pointless static qualifier in srpt_make_tpg() YueHaibing
2018-11-16 1:59 ` Leon Romanovsky
2018-11-20 3:43 ` Bart Van Assche
2018-11-21 23:51 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox