From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dimitris Papavasiliou <dpapavas@gmail.com>
Cc: alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute()
Date: Fri, 21 Dec 2018 12:00:56 +0000 [thread overview]
Message-ID: <20181221120056.GD2240@kadam> (raw)
In-Reply-To: <f8f14c6a-46c2-995d-2df4-4ae821e1b895@gmail.com>
On Fri, Dec 21, 2018 at 01:23:37PM +0200, Dimitris Papavasiliou wrote:
> On 12/21/18 11:11 AM, Dan Carpenter wrote:
> > We accidentally call mutex_unlock(&pcm512x->mutex); twice in a row.
>
> Ooops... Looks like I left a spare unlock in there. Thanks for
> catching and fixing it!
Static analysis stuff... No big deal.
>
> Maintainers, please let me know if there's anything I need to do
> with respect to this.
All you need to is reply with a reviewed-by tag so we can mark on the
fix that you approved it.
Reviewed-by: Your Name <email>
regards,
dan carpenter
next prev parent reply other threads:[~2018-12-21 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 9:11 [PATCH] ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute() Dan Carpenter
2018-12-21 11:23 ` Dimitris Papavasiliou
2018-12-21 12:00 ` Dan Carpenter [this message]
2018-12-21 12:10 ` Mark Brown
2018-12-21 13:54 ` Dimitris Papavasiliou
2018-12-21 13:42 ` Applied "ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute()" to the asoc tree Mark Brown
2018-12-21 13:51 ` [PATCH] ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute() Dimitris Papavasiliou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221120056.GD2240@kadam \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dpapavas@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox