From: Dimitris Papavasiliou <dpapavas@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute()
Date: Fri, 21 Dec 2018 13:51:16 +0000 [thread overview]
Message-ID: <70125712-3f2a-3ff9-a8a2-61018dd6ba1c@gmail.com> (raw)
In-Reply-To: <20181221091120.GG2735@kadam>
On 12/21/18 11:11 AM, Dan Carpenter wrote:
> We accidentally call mutex_unlock(&pcm512x->mutex); twice in a row.
>
> I re-wrote the error handling to use "goto unlock;" instead of returning
> directly. Hopefully, it makes the code a little simpler.
>
> Fixes: 3500f1c589e9 ("ASoC: pcm512x: Implement the digital_mute interface")
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
> ---
> sound/soc/codecs/pcm512x.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
Reviewed-by: Dimitris Papavasiliou <dpapavas@gmail.com>
prev parent reply other threads:[~2018-12-21 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 9:11 [PATCH] ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute() Dan Carpenter
2018-12-21 11:23 ` Dimitris Papavasiliou
2018-12-21 12:00 ` Dan Carpenter
2018-12-21 12:10 ` Mark Brown
2018-12-21 13:54 ` Dimitris Papavasiliou
2018-12-21 13:42 ` Applied "ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute()" to the asoc tree Mark Brown
2018-12-21 13:51 ` Dimitris Papavasiliou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70125712-3f2a-3ff9-a8a2-61018dd6ba1c@gmail.com \
--to=dpapavas@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox