* Re: [PATCH 12/20] dmaengine: dw: drop useless LIST_HEAD
@ 2019-01-02 6:15 Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-01-02 6:15 UTC (permalink / raw)
To: Julia Lawall
Cc: Viresh Kumar, kernel-janitors, Andy Shevchenko, Dan Williams,
dmaengine, linux-kernel
On 23-12-18, 09:57, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> Commit ab703f818ac3 ("dmaengine: dw: lazy allocation of dma
> descriptors") removed the uses, but not the declaration.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
> ... when != x
> // </smpl>
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH 12/20] dmaengine: dw: drop useless LIST_HEAD
@ 2018-12-23 8:57 Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2018-12-23 8:57 UTC (permalink / raw)
To: Viresh Kumar
Cc: kernel-janitors, Andy Shevchenko, Vinod Koul, Dan Williams,
dmaengine, linux-kernel
Drop LIST_HEAD where the variable it declares is never used.
Commit ab703f818ac3 ("dmaengine: dw: lazy allocation of dma
descriptors") removed the uses, but not the declaration.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
@@
- LIST_HEAD(x);
... when != x
// </smpl>
Fixes: ab703f818ac3 ("dmaengine: dw: lazy allocation of dma descriptors")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Successfully 0-day tested on 151 configurations.
drivers/dma/dw/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c
index dc053e62f894..290d21be4d4c 100644
--- a/drivers/dma/dw/core.c
+++ b/drivers/dma/dw/core.c
@@ -1150,7 +1150,6 @@ static void dwc_free_chan_resources(struct dma_chan *chan)
struct dw_dma_chan *dwc = to_dw_dma_chan(chan);
struct dw_dma *dw = to_dw_dma(chan->device);
unsigned long flags;
- LIST_HEAD(list);
dev_dbg(chan2dev(chan), "%s: descs allocated=%u\n", __func__,
dwc->descs_allocated);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-02 6:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-02 6:15 [PATCH 12/20] dmaengine: dw: drop useless LIST_HEAD Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-12-23 8:57 Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox