public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] scsi: lpfc: Remove set but not used variable 'phys_id'
Date: Fri, 15 Feb 2019 07:44:15 +0000	[thread overview]
Message-ID: <20190215074415.GE2326@kadam> (raw)
In-Reply-To: <1536804299-64730-1-git-send-email-yuehaibing@huawei.com>

Signed-off-by is like a legal document to say that you haven't added
any proprietary SCO UNIXWARE code to the patch.  You have sign every
patch if you email it.

Acked-by and Reviewed-by are less clear.  Acked-by means you want it
to be merged, I guess?  I never use Acked by because I'm not a
maintainer so it's not my place to approve things.

regards,
dan carpenter

  parent reply	other threads:[~2019-02-15  7:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13  1:58 [PATCH -next] scsi: lpfc: Remove set but not used variable 'sgl_size' YueHaibing
2018-09-14 10:41 ` [PATCH -next] scsi: lpfc: Remove set but not used variables 'fc_hdr' and 'hw_page_size' YueHaibing
2018-09-17  7:02 ` [PATCH -next] scsi: lpfc: Remove set but not used variable 'sgl_size' Martin K. Petersen
2018-09-29 13:53 ` [PATCH -next] scsi: lpfc: Remove set but not used variable 'psli' YueHaibing
2018-10-04 10:51 ` [PATCH -next] scsi: lpfc: Remove set but not used variables 'tgtp' YueHaibing
2018-10-17  1:47 ` [PATCH -next] scsi: lpfc: Remove set but not used variable 'psli' Martin K. Petersen
2018-10-17  1:58 ` [PATCH -next] scsi: lpfc: Remove set but not used variables 'tgtp' Martin K. Petersen
2018-12-11  8:21 ` [PATCH -next] scsi: lpfc: Remove set but not used variable 'maxch' YueHaibing
2019-02-14 18:52 ` [PATCH -next] scsi: lpfc: Remove set but not used variable 'phys_id' James Smart
2019-02-14 19:39 ` James Bottomley
2019-02-14 19:46 ` Martin K. Petersen
2019-02-14 21:19 ` James Smart
2019-02-14 21:24 ` James Bottomley
2019-02-15  7:44 ` Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-02-14  1:51 YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190215074415.GE2326@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox