* [PATCH] net: drop pointless static qualifier in atl2_probe()
2019-02-19 14:32 [PATCH] net: drop pointless static qualifier in atl2_probe() Mao Wenan
@ 2019-02-19 14:33 ` Mao Wenan
2019-02-19 14:34 ` Dan Carpenter
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Mao Wenan @ 2019-02-19 14:33 UTC (permalink / raw)
To: kernel-janitors
There is no need to have the 'T *v' variable static
since new value always be assigned before use it.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/net/ethernet/atheros/atlx/atl2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c
index bb41becb6609..6bd686b26837 100644
--- a/drivers/net/ethernet/atheros/atlx/atl2.c
+++ b/drivers/net/ethernet/atheros/atlx/atl2.c
@@ -1335,13 +1335,11 @@ static int atl2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
{
struct net_device *netdev;
struct atl2_adapter *adapter;
- static int cards_found;
+ int cards_found = 0;
unsigned long mmio_start;
int mmio_len;
int err;
- cards_found = 0;
-
err = pci_enable_device(pdev);
if (err)
return err;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: drop pointless static qualifier in atl2_probe()
2019-02-19 14:32 [PATCH] net: drop pointless static qualifier in atl2_probe() Mao Wenan
2019-02-19 14:33 ` Mao Wenan
@ 2019-02-19 14:34 ` Dan Carpenter
2019-02-19 14:36 ` Dan Carpenter
2019-02-22 3:17 ` maowenan
3 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2019-02-19 14:34 UTC (permalink / raw)
To: kernel-janitors
On Tue, Feb 19, 2019 at 10:32:52PM +0800, Mao Wenan wrote:
> There is no need to have the 'T *v' variable static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/net/ethernet/atheros/atlx/atl2.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c
> index bb41becb6609..6bd686b26837 100644
> --- a/drivers/net/ethernet/atheros/atlx/atl2.c
> +++ b/drivers/net/ethernet/atheros/atlx/atl2.c
> @@ -1335,13 +1335,11 @@ static int atl2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> {
> struct net_device *netdev;
> struct atl2_adapter *adapter;
> - static int cards_found;
> + int cards_found = 0;
> unsigned long mmio_start;
> int mmio_len;
> int err;
>
> - cards_found = 0;
You're sending patches too quickly and you're not thinking about what
you're doing. If someone asks you to redo a patch, that should take
over night to accomplish when you take time to think about what you're
doing, but you have sent several versions of a patch in the same day.
This one is obviously wrong, but please take some time and slow down
before resending.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: drop pointless static qualifier in atl2_probe()
2019-02-19 14:32 [PATCH] net: drop pointless static qualifier in atl2_probe() Mao Wenan
2019-02-19 14:33 ` Mao Wenan
2019-02-19 14:34 ` Dan Carpenter
@ 2019-02-19 14:36 ` Dan Carpenter
2019-02-22 3:17 ` maowenan
3 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2019-02-19 14:36 UTC (permalink / raw)
To: kernel-janitors
You send this one twice. You didn't CC netdev so no one is going to
apply it.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: drop pointless static qualifier in atl2_probe()
2019-02-19 14:32 [PATCH] net: drop pointless static qualifier in atl2_probe() Mao Wenan
` (2 preceding siblings ...)
2019-02-19 14:36 ` Dan Carpenter
@ 2019-02-22 3:17 ` maowenan
3 siblings, 0 replies; 5+ messages in thread
From: maowenan @ 2019-02-22 3:17 UTC (permalink / raw)
To: kernel-janitors
On 2019/2/19 22:34, Dan Carpenter wrote:
> On Tue, Feb 19, 2019 at 10:32:52PM +0800, Mao Wenan wrote:
>> There is no need to have the 'T *v' variable static
>> since new value always be assigned before use it.
>>
>> Signed-off-by: Mao Wenan <maowenan@huawei.com>
>> ---
>> drivers/net/ethernet/atheros/atlx/atl2.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c
>> index bb41becb6609..6bd686b26837 100644
>> --- a/drivers/net/ethernet/atheros/atlx/atl2.c
>> +++ b/drivers/net/ethernet/atheros/atlx/atl2.c
>> @@ -1335,13 +1335,11 @@ static int atl2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>> {
>> struct net_device *netdev;
>> struct atl2_adapter *adapter;
>> - static int cards_found;
>> + int cards_found = 0;
>> unsigned long mmio_start;
>> int mmio_len;
>> int err;
>>
>> - cards_found = 0;
>
> You're sending patches too quickly and you're not thinking about what
> you're doing. If someone asks you to redo a patch, that should take
> over night to accomplish when you take time to think about what you're
> doing, but you have sent several versions of a patch in the same day.
>
> This one is obviously wrong, but please take some time and slow down
> before resending.
I'm sorry for this, I have checked again, that the fixes will be as below:
diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c
index bb41becb6609..31ff1e0d1baa 100644
--- a/drivers/net/ethernet/atheros/atlx/atl2.c
+++ b/drivers/net/ethernet/atheros/atlx/atl2.c
@@ -1335,13 +1335,11 @@ static int atl2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
{
struct net_device *netdev;
struct atl2_adapter *adapter;
- static int cards_found;
+ static int cards_found = 0;
unsigned long mmio_start;
int mmio_len;
int err;
- cards_found = 0;
-
err = pci_enable_device(pdev);
if (err)
return err;
>
> regards,
> dan carpenter
>
>
>
> .
>
^ permalink raw reply related [flat|nested] 5+ messages in thread