* [PATCH] drm/nouveau/dmem: Fix a NULL vs IS_ERR() check
@ 2019-02-22 6:34 Dan Carpenter
2019-02-26 1:38 ` Ben Skeggs
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-02-22 6:34 UTC (permalink / raw)
To: Ben Skeggs, Jérôme Glisse
Cc: David Airlie, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Daniel Vetter
The hmm_devmem_add() function doesn't return NULL, it returns error
pointers.
Fixes: 5be73b690875 ("drm/nouveau/dmem: device memory helpers for SVM")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c
index aa9fec80492d..28624dd0c920 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dmem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c
@@ -623,7 +623,7 @@ nouveau_dmem_init(struct nouveau_drm *drm)
*/
drm->dmem->devmem = hmm_devmem_add(&nouveau_dmem_devmem_ops,
device, size);
- if (drm->dmem->devmem = NULL) {
+ if (IS_ERR(drm->dmem->devmem)) {
kfree(drm->dmem);
drm->dmem = NULL;
return;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/nouveau/dmem: Fix a NULL vs IS_ERR() check
2019-02-22 6:34 [PATCH] drm/nouveau/dmem: Fix a NULL vs IS_ERR() check Dan Carpenter
@ 2019-02-26 1:38 ` Ben Skeggs
0 siblings, 0 replies; 2+ messages in thread
From: Ben Skeggs @ 2019-02-26 1:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, nouveau, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
dri-devel, Daniel Vetter
Got it, thanks!
On Fri, Feb 22, 2019 at 4:34 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The hmm_devmem_add() function doesn't return NULL, it returns error
> pointers.
>
> Fixes: 5be73b690875 ("drm/nouveau/dmem: device memory helpers for SVM")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c
> index aa9fec80492d..28624dd0c920 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_dmem.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c
> @@ -623,7 +623,7 @@ nouveau_dmem_init(struct nouveau_drm *drm)
> */
> drm->dmem->devmem = hmm_devmem_add(&nouveau_dmem_devmem_ops,
> device, size);
> - if (drm->dmem->devmem = NULL) {
> + if (IS_ERR(drm->dmem->devmem)) {
> kfree(drm->dmem);
> drm->dmem = NULL;
> return;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-26 1:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-22 6:34 [PATCH] drm/nouveau/dmem: Fix a NULL vs IS_ERR() check Dan Carpenter
2019-02-26 1:38 ` Ben Skeggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox