public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] csky: Cache and TLB routines
Date: Fri, 03 May 2019 13:12:16 +0000	[thread overview]
Message-ID: <20190503131147.GK29695@mwanda> (raw)

Hello Guo Ren,

This is a semi-automatic email about new static checker warnings.

The patch 00a9730e1007: "csky: Cache and TLB routines" from Sep 5,
2018, leads to the following Smatch complaint:

    ./arch/csky/mm/tlb.c:130 flush_tlb_page()
    warn: variable dereferenced before check 'vma' (see line 128)

./arch/csky/mm/tlb.c
   127		int cpu = smp_processor_id();
   128		int newpid = cpu_asid(cpu, vma->vm_mm);
                                           ^^^^^^^^^^
Dereferenced

   129	
   130		if (!vma || cpu_context(cpu, vma->vm_mm) != 0) {
                    ^^^^
Checked too late.

   131			page &= (PAGE_MASK << 1);
   132	

regards,
dan carpenter

                 reply	other threads:[~2019-05-03 13:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503131147.GK29695@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox