public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
* [bug report] csky: Cache and TLB routines
@ 2019-05-03 13:12 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2019-05-03 13:12 UTC (permalink / raw)
  To: kernel-janitors

Hello Guo Ren,

This is a semi-automatic email about new static checker warnings.

The patch 00a9730e1007: "csky: Cache and TLB routines" from Sep 5,
2018, leads to the following Smatch complaint:

    ./arch/csky/mm/tlb.c:130 flush_tlb_page()
    warn: variable dereferenced before check 'vma' (see line 128)

./arch/csky/mm/tlb.c
   127		int cpu = smp_processor_id();
   128		int newpid = cpu_asid(cpu, vma->vm_mm);
                                           ^^^^^^^^^^
Dereferenced

   129	
   130		if (!vma || cpu_context(cpu, vma->vm_mm) != 0) {
                    ^^^^
Checked too late.

   131			page &= (PAGE_MASK << 1);
   132	

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-05-03 13:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-03 13:12 [bug report] csky: Cache and TLB routines Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox