* Re: [3/3] i2c: qup: Use devm_platform_ioremap_resource helper
[not found] <20190916190254.GA14207@SD>
@ 2019-09-17 15:40 ` Markus Elfring
2019-09-17 16:50 ` Saiyam Doshi
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2019-09-17 15:40 UTC (permalink / raw)
To: Saiyam Doshi, Andy Gross, linux-arm-msm, linux-i2c
Cc: linux-kernel, kernel-janitors
> Use devm_platform_ioremap_resource helper which wraps
> platform_get_resource() and devm_ioremap_resource() together.
Can a wording like “Simplify this function implementation by using
a known wrapper function.” be nicer for this change description?
> The semantic patch that makes this report is available
> in scripts/coccinelle/api/devm_platform_ioremap_resource.cocci.
>
> Found using - http://coccinelle.lip6.fr/
Can a tag like “Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci”
be more helpful than the other description variant?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [3/3] i2c: qup: Use devm_platform_ioremap_resource helper
2019-09-17 15:40 ` [3/3] i2c: qup: Use devm_platform_ioremap_resource helper Markus Elfring
@ 2019-09-17 16:50 ` Saiyam Doshi
0 siblings, 0 replies; 2+ messages in thread
From: Saiyam Doshi @ 2019-09-17 16:50 UTC (permalink / raw)
To: Markus Elfring
Cc: Andy Gross, linux-arm-msm, linux-i2c, linux-kernel,
kernel-janitors
On Tue, Sep 17, 2019 at 05:40:14PM +0200, Markus Elfring wrote:
> > Use devm_platform_ioremap_resource helper which wraps
> > platform_get_resource() and devm_ioremap_resource() together.
>
> Can a wording like “Simplify this function implementation by using
> a known wrapper function.” be nicer for this change description?
Okay. I will change as actual change and changelog is almost similar :)
> > The semantic patch that makes this report is available
> > in scripts/coccinelle/api/devm_platform_ioremap_resource.cocci.
> >
> > Found using - http://coccinelle.lip6.fr/
>
> Can a tag like “Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci”
> be more helpful than the other description variant?
will update this in changelog and resend this series.
-Saiyam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-17 16:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190916190254.GA14207@SD>
2019-09-17 15:40 ` [3/3] i2c: qup: Use devm_platform_ioremap_resource helper Markus Elfring
2019-09-17 16:50 ` Saiyam Doshi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox