From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USB HID random timeout failures fixed by trying 20 times
Date: Tue, 04 Feb 2020 06:27:49 +0000 [thread overview]
Message-ID: <20200204062749.GP1778@kadam> (raw)
In-Reply-To: <d15b7fa7-596c-96f8-dd07-7831a9fa2f0e@gmail.com>
Hi Lauri,
There are a bunch of issues with this patch.
1) There is no way we're going to add a retry loop to
usb_control_msg(). We might add it to a driver, but probably we
would suspect that the hardware is bad. Maybe the cable is faulty?
Or I could be wrong on that...
2) You would need to send this to a different list. Use
./scripts/get_maintainer.pl to find out who. The
linux-usb@vger.kernel.org is the main USB list.
3) The patch doesn't apply. Read the first paragraph of
Documentation/process/email-clients.rst
4) The subject needs to be formatted slightly differently.
[PATCH] USB: HID: Fix timeout by adding retry loop
5) The commit message should be more clear what was affected. Don't
start the commit message in the middle of a sentence.
regards,
dan carpenter
next prev parent reply other threads:[~2020-02-04 6:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 4:27 [PATCH] USB HID random timeout failures fixed by trying 20 times Lauri Jakku
2020-02-04 6:27 ` Dan Carpenter [this message]
2020-02-04 7:00 ` [PATCH] USB: HID: Fix timeout by adding retry loop Lauri Jakku
2020-02-04 7:18 ` Dan Carpenter
2021-08-10 13:40 ` USB Hid Timeout and r8169 module to trust HW if present Late @ Gmail
2021-08-10 14:11 ` Late @ Gmail
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204062749.GP1778@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox