From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USB: HID: Fix timeout by adding retry loop
Date: Tue, 04 Feb 2020 07:18:49 +0000 [thread overview]
Message-ID: <20200204071849.GQ1778@kadam> (raw)
In-Reply-To: <51d8ee09-7cd6-5304-00b0-99276e67aec1@gmail.com>
On Tue, Feb 04, 2020 at 09:00:46AM +0200, Lauri Jakku wrote:
> Hi,
>
> I'm quite newbie publicly patching stuff, but at anyway:
>
> On 4.2.2020 8.27, Dan Carpenter wrote:
> > Hi Lauri,
> >
> > There are a bunch of issues with this patch.
> >
> > 1) There is no way we're going to add a retry loop to
> > usb_control_msg(). We might add it to a driver, but probably we
> > would suspect that the hardware is bad. Maybe the cable is faulty?
> > Or I could be wrong on that...
>
> For example there is lot of USB HID related oddities reported
>
> by multiple users, that have said that after (kernel) update
>
> of their system USB devices stopped working or work randomly.
>
>
> I have problem with my mouse, and the problem went away
>
> with my patch. I think that the change to driver by driver is
>
> just code duplication, and with my patch the 'good' HW still
>
> is not going to sleep even that 20ms, the time that I tought
>
> to be good. Max retry time is 400ms.
>
That doesn't sound totally unreasonable. Go ahead and try sending the
patch. Maybe they apply it or maybe they don't but either way there
is no harm in sending a patch.
regards,
dan carpenter
next prev parent reply other threads:[~2020-02-04 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 4:27 [PATCH] USB HID random timeout failures fixed by trying 20 times Lauri Jakku
2020-02-04 6:27 ` Dan Carpenter
2020-02-04 7:00 ` [PATCH] USB: HID: Fix timeout by adding retry loop Lauri Jakku
2020-02-04 7:18 ` Dan Carpenter [this message]
2021-08-10 13:40 ` USB Hid Timeout and r8169 module to trust HW if present Late @ Gmail
2021-08-10 14:11 ` Late @ Gmail
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204071849.GQ1778@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox