From: Colin King <colin.king@canonical.com>
To: Mike Marshall <hubcap@omnibond.com>,
Martin Brandenburg <martin@omnibond.com>,
devel@lists.orangefs.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] orangefs: remove redundant assignment to variable ret
Date: Sun, 24 May 2020 22:48:02 +0000 [thread overview]
Message-ID: <20200524224802.27850-1-colin.king@canonical.com> (raw)
In-Reply-To: <20190511132700.4862-1-colin.king@canonical.com>
From: Colin Ian King <colin.king@canonical.com>
The variable ret is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/orangefs/orangefs-mod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/orangefs/orangefs-mod.c b/fs/orangefs/orangefs-mod.c
index c010c1fddafc..289b648ae196 100644
--- a/fs/orangefs/orangefs-mod.c
+++ b/fs/orangefs/orangefs-mod.c
@@ -79,7 +79,7 @@ DECLARE_WAIT_QUEUE_HEAD(orangefs_request_list_waitq);
static int __init orangefs_init(void)
{
- int ret = -1;
+ int ret;
__u32 i = 0;
if (op_timeout_secs < 0)
--
2.25.1
next prev parent reply other threads:[~2020-05-24 22:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 13:27 [PATCH] orangefs: remove redundant assignment to variable buffer_index Colin King
2019-05-16 16:06 ` Mike Marshall
2019-05-21 15:03 ` Dan Carpenter
2019-06-25 18:55 ` Mike Marshall
2019-06-26 6:18 ` Dan Carpenter
2019-06-26 14:56 ` Colin Ian King
2019-05-21 15:01 ` Dan Carpenter
2019-07-28 18:04 ` [PATCH] orangefs: remove redundant assignment to err Colin King
2020-05-24 22:48 ` Colin King [this message]
2020-06-01 11:15 ` [PATCH] orangefs: remove redundant assignment to variable ret Mike Marshall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524224802.27850-1-colin.king@canonical.com \
--to=colin.king@canonical.com \
--cc=devel@lists.orangefs.org \
--cc=hubcap@omnibond.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@omnibond.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox