From: Colin Ian King <colin.king@canonical.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Mike Marshall <hubcap@omnibond.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Martin Brandenburg <martin@omnibond.com>,
devel@lists.orangefs.org, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] orangefs: remove redundant assignment to variable buffer_index
Date: Wed, 26 Jun 2019 14:56:42 +0000 [thread overview]
Message-ID: <712efbc2-1c10-8e6e-7517-16fa57cb8709@canonical.com> (raw)
In-Reply-To: <20190626061801.GA18776@kadam>
On 26/06/2019 07:18, Dan Carpenter wrote:
> On Tue, Jun 25, 2019 at 02:55:11PM -0400, Mike Marshall wrote:
>>>> You often send these patches before they hit linux-next so I had skipped
>>>> reviewing this one when you sent it.
>>
>> I know Linus is likely to refuse pull requests for stuff that
>> has not been through linux-next, so I make sure stuff has been
>> there at least a few days before asking for it to be pulled.
>> "A few days" is long enough for robots to see it, perhaps not
>> long enough for humans. I especially appreciate the human review. One of
>> the good things about Orangefs is that it is easy to install and configure,
>> especially for testing. Documentation/filesystems/orangefs.txt has
>> instructions for dnf installing orangefs on Fedora, and also how to download
>> a source tarball and install from that.
>
> No, no, that comment was to Colin. It's good that he's sending patches
> for all the trees as soon as possible like the zero day bot does. But
> it does make it hard to review at times.
>
> regards,
> dan carpenter
>
Indeed, I normally work against the latest code landing in linux-next,
so apologies for any confusion. Anyhow, by the look of it these minor
nitpicks still need addressing (really low priority), so shall I leave
that with you Mike to sort out?
Colin
next prev parent reply other threads:[~2019-06-26 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 13:27 [PATCH] orangefs: remove redundant assignment to variable buffer_index Colin King
2019-05-16 16:06 ` Mike Marshall
2019-05-21 15:03 ` Dan Carpenter
2019-06-25 18:55 ` Mike Marshall
2019-06-26 6:18 ` Dan Carpenter
2019-06-26 14:56 ` Colin Ian King [this message]
2019-05-21 15:01 ` Dan Carpenter
2019-07-28 18:04 ` [PATCH] orangefs: remove redundant assignment to err Colin King
2020-05-24 22:48 ` [PATCH] orangefs: remove redundant assignment to variable ret Colin King
2020-06-01 11:15 ` Mike Marshall
-- strict thread matches above, loose matches on Subject: below --
2022-10-17 21:49 [PATCH] orangefs: remove redundant assignment to variable buffer_index Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=712efbc2-1c10-8e6e-7517-16fa57cb8709@canonical.com \
--to=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@lists.orangefs.org \
--cc=hubcap@omnibond.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@omnibond.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox