From: Jan Kara <jack@suse.cz>
To: Colin King <colin.king@canonical.com>
Cc: Pan Bian <bianpan2016@163.com>, Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] isofs: remove redundant continue statement
Date: Thu, 17 Jun 2021 17:12:16 +0200 [thread overview]
Message-ID: <20210617151216.GH32587@quack2.suse.cz> (raw)
In-Reply-To: <20210617120837.11994-1-colin.king@canonical.com>
On Thu 17-06-21 13:08:37, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The continue statement in the while-loop has no effect,
> remove it.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks! I've added the patch to my tree.
Honza
> ---
> fs/isofs/dir.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c
> index b9e6a7ec78be..eb2f8273e6f1 100644
> --- a/fs/isofs/dir.c
> +++ b/fs/isofs/dir.c
> @@ -235,8 +235,6 @@ static int do_isofs_readdir(struct inode *inode, struct file *file,
> break;
> }
> ctx->pos += de_len;
> -
> - continue;
> }
> if (bh)
> brelse(bh);
> --
> 2.31.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2021-06-17 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 12:08 [PATCH] isofs: remove redundant continue statement Colin King
2021-06-17 15:12 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617151216.GH32587@quack2.suse.cz \
--to=jack@suse.cz \
--cc=bianpan2016@163.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox