* [PATCH] isofs: remove redundant continue statement
@ 2021-06-17 12:08 Colin King
2021-06-17 15:12 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-06-17 12:08 UTC (permalink / raw)
To: Pan Bian, Jan Kara, linux-kernel; +Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
The continue statement in the while-loop has no effect,
remove it.
Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/isofs/dir.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c
index b9e6a7ec78be..eb2f8273e6f1 100644
--- a/fs/isofs/dir.c
+++ b/fs/isofs/dir.c
@@ -235,8 +235,6 @@ static int do_isofs_readdir(struct inode *inode, struct file *file,
break;
}
ctx->pos += de_len;
-
- continue;
}
if (bh)
brelse(bh);
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] isofs: remove redundant continue statement
2021-06-17 12:08 [PATCH] isofs: remove redundant continue statement Colin King
@ 2021-06-17 15:12 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2021-06-17 15:12 UTC (permalink / raw)
To: Colin King; +Cc: Pan Bian, Jan Kara, linux-kernel, kernel-janitors
On Thu 17-06-21 13:08:37, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The continue statement in the while-loop has no effect,
> remove it.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks! I've added the patch to my tree.
Honza
> ---
> fs/isofs/dir.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c
> index b9e6a7ec78be..eb2f8273e6f1 100644
> --- a/fs/isofs/dir.c
> +++ b/fs/isofs/dir.c
> @@ -235,8 +235,6 @@ static int do_isofs_readdir(struct inode *inode, struct file *file,
> break;
> }
> ctx->pos += de_len;
> -
> - continue;
> }
> if (bh)
> brelse(bh);
> --
> 2.31.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-17 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-17 12:08 [PATCH] isofs: remove redundant continue statement Colin King
2021-06-17 15:12 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox