* [PATCH] vduse: missing error code in vduse_init()
@ 2021-09-07 7:32 Dan Carpenter
2021-09-07 8:40 ` Yongji Xie
2021-09-07 9:06 ` Jason Wang
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-09-07 7:32 UTC (permalink / raw)
To: Michael S. Tsirkin, Xie Yongji
Cc: Jason Wang, virtualization, kernel-janitors
This should return -ENOMEM if alloc_workqueue() fails. Currently it
returns success.
Fixes: b66219796563 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/vdpa/vdpa_user/vduse_dev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
index 5c25ff6483ad..fcd7de8dd1f2 100644
--- a/drivers/vdpa/vdpa_user/vduse_dev.c
+++ b/drivers/vdpa/vdpa_user/vduse_dev.c
@@ -1593,8 +1593,10 @@ static int vduse_init(void)
vduse_irq_wq = alloc_workqueue("vduse-irq",
WQ_HIGHPRI | WQ_SYSFS | WQ_UNBOUND, 0);
- if (!vduse_irq_wq)
+ if (!vduse_irq_wq) {
+ ret = -ENOMEM;
goto err_wq;
+ }
ret = vduse_domain_init();
if (ret)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vduse: missing error code in vduse_init()
2021-09-07 7:32 [PATCH] vduse: missing error code in vduse_init() Dan Carpenter
@ 2021-09-07 8:40 ` Yongji Xie
2021-09-07 9:06 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Yongji Xie @ 2021-09-07 8:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Michael S. Tsirkin, Jason Wang, virtualization, kernel-janitors
On Tue, Sep 7, 2021 at 3:32 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> This should return -ENOMEM if alloc_workqueue() fails. Currently it
> returns success.
>
> Fixes: b66219796563 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/vdpa/vdpa_user/vduse_dev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Thank you for the fix.
Reviewed-by: Xie Yongji <xieyongji@bytedance.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vduse: missing error code in vduse_init()
2021-09-07 7:32 [PATCH] vduse: missing error code in vduse_init() Dan Carpenter
2021-09-07 8:40 ` Yongji Xie
@ 2021-09-07 9:06 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2021-09-07 9:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: Michael S. Tsirkin, Xie Yongji, virtualization, kernel-janitors
On Tue, Sep 7, 2021 at 3:32 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> This should return -ENOMEM if alloc_workqueue() fails. Currently it
> returns success.
>
> Fixes: b66219796563 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/vdpa/vdpa_user/vduse_dev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
> index 5c25ff6483ad..fcd7de8dd1f2 100644
> --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> @@ -1593,8 +1593,10 @@ static int vduse_init(void)
>
> vduse_irq_wq = alloc_workqueue("vduse-irq",
> WQ_HIGHPRI | WQ_SYSFS | WQ_UNBOUND, 0);
> - if (!vduse_irq_wq)
> + if (!vduse_irq_wq) {
> + ret = -ENOMEM;
> goto err_wq;
> + }
>
> ret = vduse_domain_init();
> if (ret)
> --
> 2.20.1
>
Acked-by: Jason Wang <jasowang@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-07 9:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-07 7:32 [PATCH] vduse: missing error code in vduse_init() Dan Carpenter
2021-09-07 8:40 ` Yongji Xie
2021-09-07 9:06 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox