* [PATCH] drm/i915/tc: Delete bogus NULL check in intel_ddi_encoder_destroy()
@ 2021-10-04 10:37 Dan Carpenter
2021-10-05 19:26 ` Ville Syrjälä
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-10-04 10:37 UTC (permalink / raw)
To: Jani Nikula
Cc: Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter,
Ville Syrjälä, Lucas De Marchi, Imre Deak,
José Roberto de Souza, Matt Roper, Dave Airlie, intel-gfx,
dri-devel, kernel-janitors
The "digi_port" pointer can't be NULL and we have already dereferenced
it so checking for NULL is not necessary. Delete the check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 51d07e9af9f3..b9c6eb13804f 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -4025,8 +4025,7 @@ static void intel_ddi_encoder_destroy(struct drm_encoder *encoder)
intel_display_power_flush_work(i915);
drm_encoder_cleanup(encoder);
- if (dig_port)
- kfree(dig_port->hdcp_port_data.streams);
+ kfree(dig_port->hdcp_port_data.streams);
kfree(dig_port);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915/tc: Delete bogus NULL check in intel_ddi_encoder_destroy()
2021-10-04 10:37 [PATCH] drm/i915/tc: Delete bogus NULL check in intel_ddi_encoder_destroy() Dan Carpenter
@ 2021-10-05 19:26 ` Ville Syrjälä
0 siblings, 0 replies; 2+ messages in thread
From: Ville Syrjälä @ 2021-10-05 19:26 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Lucas De Marchi, Imre Deak,
José Roberto de Souza, Matt Roper, Dave Airlie, intel-gfx,
dri-devel, kernel-janitors
On Mon, Oct 04, 2021 at 01:37:37PM +0300, Dan Carpenter wrote:
> The "digi_port" pointer can't be NULL and we have already dereferenced
> it so checking for NULL is not necessary. Delete the check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks. Applied to drm-intel-next.
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 51d07e9af9f3..b9c6eb13804f 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -4025,8 +4025,7 @@ static void intel_ddi_encoder_destroy(struct drm_encoder *encoder)
> intel_display_power_flush_work(i915);
>
> drm_encoder_cleanup(encoder);
> - if (dig_port)
> - kfree(dig_port->hdcp_port_data.streams);
> + kfree(dig_port->hdcp_port_data.streams);
> kfree(dig_port);
> }
>
> --
> 2.20.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-05 19:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-04 10:37 [PATCH] drm/i915/tc: Delete bogus NULL check in intel_ddi_encoder_destroy() Dan Carpenter
2021-10-05 19:26 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox