* [PATCH][next] iio: Fix uninitialized variable ret
@ 2021-10-15 15:32 Colin King
2021-10-17 11:37 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-10-15 15:32 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, Alexandru Ardelean,
Mihail Chindris, linux-iio
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
When !iio_buffer_space_available(rb) is true and signal_pending(current)
is false the end of the do-while loop is reached and the uninitialized
variable ret is zero checked. Fix this by initializing variable ret to
zero.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: ffabbffd40f2 ("iio: Add output buffer support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/iio/industrialio-buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index b884d78657cb..c97fb8462395 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -179,7 +179,7 @@ static ssize_t iio_buffer_write(struct file *filp, const char __user *buf,
struct iio_buffer *rb = ib->buffer;
struct iio_dev *indio_dev = ib->indio_dev;
DEFINE_WAIT_FUNC(wait, woken_wake_function);
- int ret;
+ int ret = 0;
size_t written;
if (!indio_dev->info)
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH][next] iio: Fix uninitialized variable ret
2021-10-15 15:32 [PATCH][next] iio: Fix uninitialized variable ret Colin King
@ 2021-10-17 11:37 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-10-17 11:37 UTC (permalink / raw)
To: Colin King
Cc: Lars-Peter Clausen, Alexandru Ardelean, Mihail Chindris,
linux-iio, kernel-janitors, linux-kernel
On Fri, 15 Oct 2021 16:32:54 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> When !iio_buffer_space_available(rb) is true and signal_pending(current)
> is false the end of the do-while loop is reached and the uninitialized
> variable ret is zero checked. Fix this by initializing variable ret to
> zero.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: ffabbffd40f2 ("iio: Add output buffer support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks like the correct fix to me. If anyone disagrees shout soon!
Applied to the iio-togreg branch of iio.git and pushed out as testing for 0-day
to poke at it.
Jonathan
> ---
> drivers/iio/industrialio-buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index b884d78657cb..c97fb8462395 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -179,7 +179,7 @@ static ssize_t iio_buffer_write(struct file *filp, const char __user *buf,
> struct iio_buffer *rb = ib->buffer;
> struct iio_dev *indio_dev = ib->indio_dev;
> DEFINE_WAIT_FUNC(wait, woken_wake_function);
> - int ret;
> + int ret = 0;
> size_t written;
>
> if (!indio_dev->info)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-17 11:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-15 15:32 [PATCH][next] iio: Fix uninitialized variable ret Colin King
2021-10-17 11:37 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox