* [PATCH] intel_th: remove redundant re-assignment of pointer hubdrv
@ 2021-12-04 23:39 Colin Ian King
2021-12-07 12:18 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2021-12-04 23:39 UTC (permalink / raw)
To: Alexander Shishkin; +Cc: kernel-janitors, linux-kernel
The pointer hubdrv is being re-assigned the same value as it was
initialized with only a few lines earlier. The re-assignment is
redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/hwtracing/intel_th/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c
index 7e753a75d23b..5de47b89a9e1 100644
--- a/drivers/hwtracing/intel_th/core.c
+++ b/drivers/hwtracing/intel_th/core.c
@@ -1048,7 +1048,6 @@ int intel_th_set_output(struct intel_th_device *thdev,
* hub is instantiated together with the source device that
* calls here, so guaranteed to be present.
*/
- hubdrv = to_intel_th_driver(hub->dev.driver);
if (!hubdrv || !try_module_get(hubdrv->driver.owner))
return -EINVAL;
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] intel_th: remove redundant re-assignment of pointer hubdrv
2021-12-04 23:39 [PATCH] intel_th: remove redundant re-assignment of pointer hubdrv Colin Ian King
@ 2021-12-07 12:18 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-12-07 12:18 UTC (permalink / raw)
To: Colin Ian King; +Cc: Alexander Shishkin, kernel-janitors, linux-kernel
On Sat, Dec 04, 2021 at 11:39:34PM +0000, Colin Ian King wrote:
> The pointer hubdrv is being re-assigned the same value as it was
> initialized with only a few lines earlier. The re-assignment is
> redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/hwtracing/intel_th/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c
> index 7e753a75d23b..5de47b89a9e1 100644
> --- a/drivers/hwtracing/intel_th/core.c
> +++ b/drivers/hwtracing/intel_th/core.c
> @@ -1048,7 +1048,6 @@ int intel_th_set_output(struct intel_th_device *thdev,
> * hub is instantiated together with the source device that
> * calls here, so guaranteed to be present.
> */
> - hubdrv = to_intel_th_driver(hub->dev.driver);
> if (!hubdrv || !try_module_get(hubdrv->driver.owner))
^^^^^^^
This NULL check doesn't make sense. "hubdrv" is "hub - some_offset"
where "some_offset" is zero. We've already dereferenced "hub" so
"hubdrv" can't be NULL.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-07 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-04 23:39 [PATCH] intel_th: remove redundant re-assignment of pointer hubdrv Colin Ian King
2021-12-07 12:18 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox