From: David Howells <dhowells@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] afs: remove redundant assignment to variable ret
Date: Sun, 12 May 2019 06:55:26 +0000 [thread overview]
Message-ID: <26748.1557644126@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190511123603.3265-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> The variable ret is being assigned a value however this is never
> read and later it is being reassigned to a new value. The assignment
> is redundant and hence can be removed.
No.
> if (ret = 0) {
> ret = acl->size;
> if (size > 0) {
> - ret = -ERANGE;
> if (acl->size > size)
> return -ERANGE;
> memcpy(buffer, acl->data, acl->size);
This is the wrong solution. acl and key need releasing, so the return should
be a goto.
David
next prev parent reply other threads:[~2019-05-12 6:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 13:58 [PATCH] afs: remove redundant assignment of dvnode to itself Colin King
2017-11-20 22:20 ` David Howells
2019-05-11 12:36 ` [PATCH] afs: remove redundant assignment to variable ret Colin King
2019-05-11 15:35 ` Joe Perches
2019-05-12 6:56 ` David Howells
2019-05-12 6:55 ` David Howells [this message]
2020-05-27 12:06 ` Colin King
2020-07-22 15:22 ` Colin King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26748.1557644126@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox