* [patch] drm: checking the wrong variable in savage_do_init_bci()
@ 2012-05-17 7:09 Dan Carpenter
2012-05-17 10:06 ` walter harms
2012-05-17 17:05 ` Ian Romanick
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-05-17 7:09 UTC (permalink / raw)
To: David Airlie
Cc: Nicolas Kaiser, Dave Airlie, kernel-janitors, Greg Dietsche,
dri-devel
drm_core_ioremap() initializes ->handle. We already know
"dev->agp_buffer_map" is a valid pointer.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
index cb1ee4e..6eb507a 100644
--- a/drivers/gpu/drm/savage/savage_bci.c
+++ b/drivers/gpu/drm/savage/savage_bci.c
@@ -735,7 +735,7 @@ static int savage_do_init_bci(struct drm_device * dev, drm_savage_init_t * init)
return -EINVAL;
}
drm_core_ioremap(dev->agp_buffer_map, dev);
- if (!dev->agp_buffer_map) {
+ if (!dev->agp_buffer_map->handle) {
DRM_ERROR("failed to ioremap DMA buffer region!\n");
savage_do_cleanup_bci(dev);
return -ENOMEM;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] drm: checking the wrong variable in savage_do_init_bci()
2012-05-17 7:09 [patch] drm: checking the wrong variable in savage_do_init_bci() Dan Carpenter
@ 2012-05-17 10:06 ` walter harms
2012-05-17 17:05 ` Ian Romanick
1 sibling, 0 replies; 3+ messages in thread
From: walter harms @ 2012-05-17 10:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nicolas Kaiser, kernel-janitors, dri-devel, Dave Airlie,
Greg Dietsche
Am 17.05.2012 09:09, schrieb Dan Carpenter:
> drm_core_ioremap() initializes ->handle. We already know
> "dev->agp_buffer_map" is a valid pointer.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
> index cb1ee4e..6eb507a 100644
> --- a/drivers/gpu/drm/savage/savage_bci.c
> +++ b/drivers/gpu/drm/savage/savage_bci.c
> @@ -735,7 +735,7 @@ static int savage_do_init_bci(struct drm_device * dev, drm_savage_init_t * init)
> return -EINVAL;
> }
> drm_core_ioremap(dev->agp_buffer_map, dev);
> - if (!dev->agp_buffer_map) {
> + if (!dev->agp_buffer_map->handle) {
> DRM_ERROR("failed to ioremap DMA buffer region!\n");
> savage_do_cleanup_bci(dev);
> return -ENOMEM;
ok, the interface asks for that type of error :)
re,
wh
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] drm: checking the wrong variable in savage_do_init_bci()
2012-05-17 7:09 [patch] drm: checking the wrong variable in savage_do_init_bci() Dan Carpenter
2012-05-17 10:06 ` walter harms
@ 2012-05-17 17:05 ` Ian Romanick
1 sibling, 0 replies; 3+ messages in thread
From: Ian Romanick @ 2012-05-17 17:05 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nicolas Kaiser, kernel-janitors, dri-devel, Dave Airlie,
Greg Dietsche
On 05/17/2012 12:09 AM, Dan Carpenter wrote:
> drm_core_ioremap() initializes ->handle. We already know
> "dev->agp_buffer_map" is a valid pointer.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
I'm surprised that has never been hit.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
>
> diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
> index cb1ee4e..6eb507a 100644
> --- a/drivers/gpu/drm/savage/savage_bci.c
> +++ b/drivers/gpu/drm/savage/savage_bci.c
> @@ -735,7 +735,7 @@ static int savage_do_init_bci(struct drm_device * dev, drm_savage_init_t * init)
> return -EINVAL;
> }
> drm_core_ioremap(dev->agp_buffer_map, dev);
> - if (!dev->agp_buffer_map) {
> + if (!dev->agp_buffer_map->handle) {
> DRM_ERROR("failed to ioremap DMA buffer region!\n");
> savage_do_cleanup_bci(dev);
> return -ENOMEM;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-17 17:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-17 7:09 [patch] drm: checking the wrong variable in savage_do_init_bci() Dan Carpenter
2012-05-17 10:06 ` walter harms
2012-05-17 17:05 ` Ian Romanick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox