* [PATCH] hfsplus: remove xattr error message
@ 2026-04-11 12:53 Colin Ian King
2026-04-13 17:12 ` Viacheslav Dubeyko
0 siblings, 1 reply; 4+ messages in thread
From: Colin Ian King @ 2026-04-11 12:53 UTC (permalink / raw)
To: Viacheslav Dubeyko, John Paul Adrian Glaubitz, Yangtao Li,
linux-fsdevel
Cc: kernel-janitors, linux-kernel
When exercising hfsplus with the stress-ng xattr stressor a large
quantity of somewhat unhelpful error messages "hfsplus: xattr exists
yet" spam the kernel log. Remove these.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/hfsplus/xattr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
index c70bb6f494b2..e10e1d8a5862 100644
--- a/fs/hfsplus/xattr.c
+++ b/fs/hfsplus/xattr.c
@@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
if (!strcmp_xattr_finder_info(name)) {
if (flags & XATTR_CREATE) {
- pr_err("xattr exists yet\n");
err = -EOPNOTSUPP;
goto end_setxattr;
}
@@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
if (hfsplus_attr_exists(inode, name)) {
if (flags & XATTR_CREATE) {
- pr_err("xattr exists yet\n");
err = -EOPNOTSUPP;
goto end_setxattr;
}
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hfsplus: remove xattr error message
2026-04-11 12:53 [PATCH] hfsplus: remove xattr error message Colin Ian King
@ 2026-04-13 17:12 ` Viacheslav Dubeyko
2026-04-14 20:19 ` Colin King (gmail)
0 siblings, 1 reply; 4+ messages in thread
From: Viacheslav Dubeyko @ 2026-04-13 17:12 UTC (permalink / raw)
To: Colin Ian King, Viacheslav Dubeyko, John Paul Adrian Glaubitz,
Yangtao Li, linux-fsdevel
Cc: kernel-janitors, linux-kernel
On Sat, 2026-04-11 at 13:53 +0100, Colin Ian King wrote:
> When exercising hfsplus with the stress-ng xattr stressor a large
> quantity of somewhat unhelpful error messages "hfsplus: xattr exists
> yet" spam the kernel log. Remove these.
We can convert it into hfs_dbg() and to add showing inode ID + name. What do you
think?
Also, there are other pr_err() in xattr code that can be converted into
hfs_dbg(). Could you please take a look into other ones too?
Thanks,
Slava.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> fs/hfsplus/xattr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
> index c70bb6f494b2..e10e1d8a5862 100644
> --- a/fs/hfsplus/xattr.c
> +++ b/fs/hfsplus/xattr.c
> @@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
>
> if (!strcmp_xattr_finder_info(name)) {
> if (flags & XATTR_CREATE) {
> - pr_err("xattr exists yet\n");
> err = -EOPNOTSUPP;
> goto end_setxattr;
> }
> @@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
>
> if (hfsplus_attr_exists(inode, name)) {
> if (flags & XATTR_CREATE) {
> - pr_err("xattr exists yet\n");
> err = -EOPNOTSUPP;
> goto end_setxattr;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hfsplus: remove xattr error message
2026-04-13 17:12 ` Viacheslav Dubeyko
@ 2026-04-14 20:19 ` Colin King (gmail)
2026-04-14 21:16 ` Viacheslav Dubeyko
0 siblings, 1 reply; 4+ messages in thread
From: Colin King (gmail) @ 2026-04-14 20:19 UTC (permalink / raw)
To: Viacheslav Dubeyko, Viacheslav Dubeyko, John Paul Adrian Glaubitz,
Yangtao Li, linux-fsdevel
Cc: kernel-janitors, linux-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1607 bytes --]
On 13/04/2026 18:12, Viacheslav Dubeyko wrote:
> On Sat, 2026-04-11 at 13:53 +0100, Colin Ian King wrote:
>> When exercising hfsplus with the stress-ng xattr stressor a large
>> quantity of somewhat unhelpful error messages "hfsplus: xattr exists
>> yet" spam the kernel log. Remove these.
>
> We can convert it into hfs_dbg() and to add showing inode ID + name. What do you
> think?
Yes, that's a good idea. Perhaps the phrase "xattr exists yet" can be
rephrased as the message is not really that clear. Any ideas for an
improved message?
Colin
>
> Also, there are other pr_err() in xattr code that can be converted into
> hfs_dbg(). Could you please take a look into other ones too?
>
> Thanks,
> Slava.
>
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>> fs/hfsplus/xattr.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
>> index c70bb6f494b2..e10e1d8a5862 100644
>> --- a/fs/hfsplus/xattr.c
>> +++ b/fs/hfsplus/xattr.c
>> @@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
>>
>> if (!strcmp_xattr_finder_info(name)) {
>> if (flags & XATTR_CREATE) {
>> - pr_err("xattr exists yet\n");
>> err = -EOPNOTSUPP;
>> goto end_setxattr;
>> }
>> @@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
>>
>> if (hfsplus_attr_exists(inode, name)) {
>> if (flags & XATTR_CREATE) {
>> - pr_err("xattr exists yet\n");
>> err = -EOPNOTSUPP;
>> goto end_setxattr;
>> }
>
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 4901 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hfsplus: remove xattr error message
2026-04-14 20:19 ` Colin King (gmail)
@ 2026-04-14 21:16 ` Viacheslav Dubeyko
0 siblings, 0 replies; 4+ messages in thread
From: Viacheslav Dubeyko @ 2026-04-14 21:16 UTC (permalink / raw)
To: Colin King (gmail), Viacheslav Dubeyko, John Paul Adrian Glaubitz,
Yangtao Li, linux-fsdevel
Cc: kernel-janitors, linux-kernel
On Tue, 2026-04-14 at 21:19 +0100, Colin King (gmail) wrote:
> On 13/04/2026 18:12, Viacheslav Dubeyko wrote:
> > On Sat, 2026-04-11 at 13:53 +0100, Colin Ian King wrote:
> > > When exercising hfsplus with the stress-ng xattr stressor a large
> > > quantity of somewhat unhelpful error messages "hfsplus: xattr exists
> > > yet" spam the kernel log. Remove these.
> >
> > We can convert it into hfs_dbg() and to add showing inode ID + name. What do you
> > think?
>
> Yes, that's a good idea. Perhaps the phrase "xattr exists yet" can be
> rephrased as the message is not really that clear. Any ideas for an
> improved message?
Maybe, "unable to recreate the existing xattr"?
Thanks,
Slava.
>
> Colin
>
> >
> > Also, there are other pr_err() in xattr code that can be converted into
> > hfs_dbg(). Could you please take a look into other ones too?
> >
> > Thanks,
> > Slava.
> >
> > >
> > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > > ---
> > > fs/hfsplus/xattr.c | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
> > > index c70bb6f494b2..e10e1d8a5862 100644
> > > --- a/fs/hfsplus/xattr.c
> > > +++ b/fs/hfsplus/xattr.c
> > > @@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
> > >
> > > if (!strcmp_xattr_finder_info(name)) {
> > > if (flags & XATTR_CREATE) {
> > > - pr_err("xattr exists yet\n");
> > > err = -EOPNOTSUPP;
> > > goto end_setxattr;
> > > }
> > > @@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
> > >
> > > if (hfsplus_attr_exists(inode, name)) {
> > > if (flags & XATTR_CREATE) {
> > > - pr_err("xattr exists yet\n");
> > > err = -EOPNOTSUPP;
> > > goto end_setxattr;
> > > }
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-14 21:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-11 12:53 [PATCH] hfsplus: remove xattr error message Colin Ian King
2026-04-13 17:12 ` Viacheslav Dubeyko
2026-04-14 20:19 ` Colin King (gmail)
2026-04-14 21:16 ` Viacheslav Dubeyko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox