* ERROR: "__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
@ 2012-09-27 11:59 Fengguang Wu
2012-09-27 13:12 ` Martin Peres
2012-09-27 21:18 ` Ben Skeggs
0 siblings, 2 replies; 3+ messages in thread
From: Fengguang Wu @ 2012-09-27 11:59 UTC (permalink / raw)
To: kernel-janitors
Hi Martin,
FYI, kernel build failed on
6310a32252e4160ce5492ad9b98c9f2778fec43b drm/nouveau/therm: calculate the pwm divisor on nv50+
powerpc-allmodconfig
All error/warnings:
ERROR: "__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: ".__floatsidf" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: "__fixdfsi" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: ".__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: "__floatsidf" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: ".__fixdfsi" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ERROR: "__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
2012-09-27 11:59 ERROR: "__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined! Fengguang Wu
@ 2012-09-27 13:12 ` Martin Peres
2012-09-27 21:18 ` Ben Skeggs
1 sibling, 0 replies; 3+ messages in thread
From: Martin Peres @ 2012-09-27 13:12 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On 27/09/2012 13:59, Fengguang Wu wrote:
> Hi Martin,
>
> FYI, kernel build failed on
>
> 6310a32252e4160ce5492ad9b98c9f2778fec43b drm/nouveau/therm: calculate the pwm divisor on nv50+
> powerpc-allmodconfig
>
> All error/warnings:
>
> ERROR: "__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> ERROR: ".__floatsidf" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> ERROR: "__fixdfsi" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> ERROR: ".__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> ERROR: "__floatsidf" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> ERROR: ".__fixdfsi" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Centre
> Fengguang Wu, Yuanhan Liu Intel Corporation
Hi,
Thank you for reporting this issue (and for having such a nice tool). I
wonder how I could miss that!
Here is a patch for this that should fix the issue. It may be squashed
into the offending commit or added as is to the tree.
Cheers,
Martin
[-- Attachment #2: 0001-drm-nouveau-therm-fix-an-unintentional-use-of-floati.patch --]
[-- Type: text/x-patch, Size: 1062 bytes --]
From 9f574fc3872b35aaa4684fa492b9a47fc8f4653f Mon Sep 17 00:00:00 2001
From: Martin Peres <martin.peres@labri.fr>
Date: Thu, 27 Sep 2012 14:34:48 +0200
Subject: [PATCH] drm/nouveau/therm: fix an unintentional use of floating
point
Signed-off-by: Martin Peres <martin.peres@labri.fr>
---
drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c b/drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c
index 6f97de2..9360ddd 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c
@@ -92,7 +92,7 @@ nv50_fan_pwm_clock(struct nouveau_therm *therm)
if (nv_rd32(therm, 0xc040) & 0x800000) {
/* Use the HOST clock (100 MHz)
* Where does this constant(2.4) comes from? */
- pwm_clock = (100000000 >> pwm_div) / 2.4;
+ pwm_clock = (100000000 >> pwm_div) * 10 / 24;
} else {
/* Where does this constant(20) comes from? */
pwm_clock = (crystal * 1000) >> pwm_div;
--
1.7.11.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: ERROR: "__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
2012-09-27 11:59 ERROR: "__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined! Fengguang Wu
2012-09-27 13:12 ` Martin Peres
@ 2012-09-27 21:18 ` Ben Skeggs
1 sibling, 0 replies; 3+ messages in thread
From: Ben Skeggs @ 2012-09-27 21:18 UTC (permalink / raw)
To: kernel-janitors
On Thu, Sep 27, 2012 at 03:12:42PM +0200, Martin Peres wrote:
> On 27/09/2012 13:59, Fengguang Wu wrote:
> > Hi Martin,
> >
> > FYI, kernel build failed on
> >
> > 6310a32252e4160ce5492ad9b98c9f2778fec43b drm/nouveau/therm: calculate the pwm divisor on nv50+
> > powerpc-allmodconfig
> >
> > All error/warnings:
> >
> > ERROR: "__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> > ERROR: ".__floatsidf" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> > ERROR: "__fixdfsi" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> > ERROR: ".__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> > ERROR: "__floatsidf" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> > ERROR: ".__fixdfsi" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
> >
> > ---
> > 0-DAY kernel build testing backend Open Source Technology Centre
> > Fengguang Wu, Yuanhan Liu Intel Corporation
> Hi,
>
> Thank you for reporting this issue (and for having such a nice tool). I
> wonder how I could miss that!
>
> Here is a patch for this that should fix the issue. It may be squashed
> into the offending commit or added as is to the tree.
Squashed into the relevant commit. Thanks!
>
> Cheers,
> Martin
>
> From 9f574fc3872b35aaa4684fa492b9a47fc8f4653f Mon Sep 17 00:00:00 2001
> From: Martin Peres <martin.peres@labri.fr>
> Date: Thu, 27 Sep 2012 14:34:48 +0200
> Subject: [PATCH] drm/nouveau/therm: fix an unintentional use of floating
> point
>
> Signed-off-by: Martin Peres <martin.peres@labri.fr>
> ---
> drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c b/drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c
> index 6f97de2..9360ddd 100644
> --- a/drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c
> +++ b/drivers/gpu/drm/nouveau/core/subdev/therm/nv50.c
> @@ -92,7 +92,7 @@ nv50_fan_pwm_clock(struct nouveau_therm *therm)
> if (nv_rd32(therm, 0xc040) & 0x800000) {
> /* Use the HOST clock (100 MHz)
> * Where does this constant(2.4) comes from? */
> - pwm_clock = (100000000 >> pwm_div) / 2.4;
> + pwm_clock = (100000000 >> pwm_div) * 10 / 24;
> } else {
> /* Where does this constant(20) comes from? */
> pwm_clock = (crystal * 1000) >> pwm_div;
> --
> 1.7.11.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-27 21:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-27 11:59 ERROR: "__divdf3" [drivers/gpu/drm/nouveau/nouveau.ko] undefined! Fengguang Wu
2012-09-27 13:12 ` Martin Peres
2012-09-27 21:18 ` Ben Skeggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox