From: Kumar Gaurav <kumargauravgupta3@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
dan.carpenter@oracle.com, emilio@elopez.com.ar,
mugunthanvnm@ti.com, jg1.han@samsung.com,
hsweeten@visionengravers.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED
Date: Fri, 09 Aug 2013 02:36:52 +0000 [thread overview]
Message-ID: <520452F4.2070804@gmail.com> (raw)
In-Reply-To: <1375997625.2087.14.camel@joe-AO722>
On Friday 09 August 2013 03:03 AM, Joe Perches wrote:
> On Thu, 2013-08-08 at 14:20 -0700, David Miller wrote:
>> From: Dan Carpenter <dan.carpenter@oracle.com>
>> Date: Fri, 9 Aug 2013 00:09:18 +0300
>>
>>> On Fri, Aug 09, 2013 at 12:50:49AM +0530, Kumar Gaurav wrote:
>>>> Removed IRQF_DISABLED as it's no-op and should be removed
>>>>
>>> What? No, that doesn't sound right.
>> The IRQ layer completely ignores the flag for several releases
>> now, it's a complete no-op as his commit message so adequately
>> states.
>>
>> So what's the problem again? :-)
I'm quite new to kernel development. I saw in one of the patches which
fixes IRQF_DISABLED issue by removing so i did.
> Wouldn't it be better to do a sed 's/IRQF_DISABLED/0/' instead?
> Maybe Kumar wants to/is doing that?
Yes i wanted to do the same and i retrieved list of all programs
containing IRQF_DISABLED but i didn't wanted to send all of them in one
patch. I would be sending them for one program in one patch.
Regards
Kumar Gaurav
next prev parent reply other threads:[~2013-08-09 2:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 19:32 [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED Kumar Gaurav
2013-08-08 21:09 ` Dan Carpenter
2013-08-08 21:11 ` Sergei Shtylyov
2013-08-08 21:20 ` David Miller
2013-08-08 21:23 ` Dan Carpenter
2013-08-08 21:33 ` Joe Perches
2013-08-09 2:36 ` Kumar Gaurav [this message]
2013-08-09 2:39 ` Joe Perches
2013-08-09 2:57 ` Kumar Gaurav
2013-08-09 2:54 ` Joe Perches
2013-08-09 3:12 ` Kumar Gaurav
2013-08-09 3:10 ` Joe Perches
2013-08-09 3:28 ` Joe Perches
2013-08-09 3:50 ` Kumar Gaurav
2013-08-09 13:15 ` Peter Senna Tschudin
2013-08-09 15:14 ` Joe Perches
2013-08-09 15:53 ` Peter Senna Tschudin
2013-08-09 16:28 ` Joe Perches
2013-08-09 7:11 ` walter harms
2013-08-09 0:59 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520452F4.2070804@gmail.com \
--to=kumargauravgupta3@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=emilio@elopez.com.ar \
--cc=hsweeten@visionengravers.com \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox