From: Kumar Gaurav <kumargauravgupta3@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
dan.carpenter@oracle.com, emilio@elopez.com.ar,
mugunthanvnm@ti.com, jg1.han@samsung.com,
hsweeten@visionengravers.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED
Date: Fri, 09 Aug 2013 03:12:01 +0000 [thread overview]
Message-ID: <52045B31.9000002@gmail.com> (raw)
In-Reply-To: <1376016864.2087.34.camel@joe-AO722>
On Friday 09 August 2013 08:24 AM, Joe Perches wrote:
> On Fri, 2013-08-09 at 08:15 +0530, Kumar Gaurav wrote:
>> On Friday 09 August 2013 08:09 AM, Joe Perches wrote:
> []
>>> And, maybe it'd be better to use IRQF_TRIGGER_NONE
>>> instead of 0.
>> I tried googling what to replace IRQF_DISABLED with but found nothing.
>> In the patch fixed earlier (not by me) it was replaced with 0 so i did
>> same. But from now on I'll use IRQF_TRIGGER_NONE. Thanks
> Maybe that's not the right thing to do.
> 0 is what's almost exclusively used.
> IRQF_TRIGGER_NONE is only used a few times.
> It's also a lot longer.
>
Sorry to poke back. But just want to confirm. I should use
IRQF_TRIGGER_NONE and not 0 right?
next prev parent reply other threads:[~2013-08-09 3:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 19:32 [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED Kumar Gaurav
2013-08-08 21:09 ` Dan Carpenter
2013-08-08 21:11 ` Sergei Shtylyov
2013-08-08 21:20 ` David Miller
2013-08-08 21:23 ` Dan Carpenter
2013-08-08 21:33 ` Joe Perches
2013-08-09 2:36 ` Kumar Gaurav
2013-08-09 2:39 ` Joe Perches
2013-08-09 2:57 ` Kumar Gaurav
2013-08-09 2:54 ` Joe Perches
2013-08-09 3:12 ` Kumar Gaurav [this message]
2013-08-09 3:10 ` Joe Perches
2013-08-09 3:28 ` Joe Perches
2013-08-09 3:50 ` Kumar Gaurav
2013-08-09 13:15 ` Peter Senna Tschudin
2013-08-09 15:14 ` Joe Perches
2013-08-09 15:53 ` Peter Senna Tschudin
2013-08-09 16:28 ` Joe Perches
2013-08-09 7:11 ` walter harms
2013-08-09 0:59 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52045B31.9000002@gmail.com \
--to=kumargauravgupta3@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=emilio@elopez.com.ar \
--cc=hsweeten@visionengravers.com \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox